Skip to content

Conversation

gares
Copy link
Member

@gares gares commented Jun 13, 2024

fix #386

@proux01
Copy link
Contributor

proux01 commented Jun 18, 2024

@gares could you try proux01@bc02eab

@gares
Copy link
Member Author

gares commented Jun 19, 2024

done, but I think there was a "race"

@proux01
Copy link
Contributor

proux01 commented Jun 19, 2024

Indeed, my bad, I rebased the branch, relaunching should now work.

@gares
Copy link
Member Author

gares commented Jun 19, 2024

Now it works, but the OOthm fails (as in Coq's CI for your PR).
So it is good enough to bench mathcomp

@proux01
Copy link
Contributor

proux01 commented Jun 20, 2024

Bench is a bit disappointing, the last commit use primproj for class->mixin builders actually makes things a bit slower:

  • mathcomp
    • before: 13:30, 1772552 kb
    • after: 13:55, 1756420 kb (+3%)
  • analysis
    • before: 12:46, 1771820 kb
    • after: 13:13, 1804272 kb (+4%)

@CohenCyril
Copy link
Member

I suspect a proper use of universe polymorphism will have a better impact.

@gares gares force-pushed the fix-proj-ty-primproj branch from 5d9ee83 to f0e45ee Compare December 11, 2024 14:58
@gares gares marked this pull request as ready for review December 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#[primitive] HB.mixin breaks the types of constants lifting mixin projections

3 participants