Skip to content

Conversation

davidwaroquiers
Copy link
Contributor

@davidwaroquiers davidwaroquiers commented May 16, 2025

Added possibility to set individual constraints in packmol.
Added some sanity checks.
Added unit tests.

Added some sanity checks.
Added unit tests.
@davidwaroquiers
Copy link
Contributor Author

@gpetretto can you do a quick check ?

@davidwaroquiers davidwaroquiers changed the title WIP: Packmol constraints Packmol constraints May 20, 2025
@davidwaroquiers davidwaroquiers marked this pull request as ready for review May 20, 2025 12:12
@davidwaroquiers
Copy link
Contributor Author

Added atoms constraints as well. This should be completely general now for use with packmol.
@gpetretto already did a first review.
This is ready for review and merge.
Thanks!

@davidwaroquiers
Copy link
Contributor Author

Hi @mkhorton @shyuep ,

This should be ready to review (and hopefully merge), there was a weird error before (related to installation of vampire on macos) but now that I merged the master it disappeared.

If there is anything missing, don't hesitate to comment or get back to me.

Thanks a lot!

@shyuep shyuep merged commit 7e7ba75 into materialsproject:master Jun 3, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants