Skip to content

Conversation

gselderslaghs
Copy link
Member

Proposed changes

Refactored buttons styling with scss mixin, to make it reusable in #565 #566

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

wuda-io
wuda-io previously approved these changes Jan 24, 2025
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about mixins, but if it makes the styles reuseable, then i am ok with it.

@gselderslaghs
Copy link
Member Author

I don't know about mixins, but if it makes the styles reuseable, then i am ok with it.

It will make the styles reusable and as a result will reduce duplicate code fragments. The mixins provides additional ways to create buttons with variable arguments as you can see in this example within the cards component, in this example the global button vars are being used, it can be set with custom value arguments as wel

@wuda-io
Copy link
Member

wuda-io commented Jan 30, 2025

This variables were used as helper vars once. They were not intended to be used as global style vars. Also long-term I think it is better to use css only approach and move away from scss and mixin functions. We can merge for now...

@wuda-io wuda-io merged commit 3321da9 into materializecss:v2-dev Jan 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants