Skip to content

Conversation

OlivierMadant
Copy link

Proposed changes

The Feature Discovery animation no longer works in 2.1.0 because the background of the component is white.
As solution, we change the component's background color and text color to use the same color as the btn-floating at the bottom right of the tap component.

Screenshots (if appropriate) or codepen:

before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@danice danice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danice danice merged commit 924db40 into materializecss:main Jul 29, 2024
@wuda-io wuda-io mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants