Skip to content

Conversation

danice
Copy link

@danice danice commented Mar 5, 2024

Proposed changes

This check is done in other places. Avoids problems when using tabs without automatic content selection.

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danice danice marked this pull request as ready for review March 5, 2024 18:33
@danice danice requested a review from wuda-io March 5, 2024 18:34
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The variable name _content could be improved in future. What does it store?
Looks more like an Element to me.

@wuda-io wuda-io merged commit 93e673c into materializecss:main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants