Skip to content

Fix modal behavior in Safari #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2020
Merged

Fix modal behavior in Safari #41

merged 2 commits into from
Oct 17, 2020

Conversation

nekonenene
Copy link

Proposed changes

In Safari (both iOS and macOS), if modal-content is vertically longer than modal, tapping underside the modal area could not close the modal. This PR fixes the problem by specifying overflow-y of modal-content.

Screenshots (if appropriate) or codepen:

Current

modal_current

After this change

modal_after

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DanielRuf DanielRuf requested a review from a team October 15, 2020 16:32
Pierstoval
Pierstoval approved these changes Oct 16, 2020
View reviewed changes
Copy link

@Pierstoval Pierstoval left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this, I don't have any iOS device to check it, but adding the overflow-y check shouldn't have an impact on other devices, so LGTM

DanielRuf
DanielRuf approved these changes Oct 17, 2020
View reviewed changes
Copy link

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielRuf DanielRuf merged commit 9dbbe83 into materializecss:v1-dev Oct 17, 2020
@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChildishGiant ChildishGiant ChildishGiant approved these changes

+2 more reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

@Pierstoval Pierstoval Pierstoval approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working component: modal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nekonenene @DanielRuf @Pierstoval @ChildishGiant @Smankusors