Skip to content

Conversation

nekonenene
Copy link

@nekonenene nekonenene commented Sep 21, 2020

Proposed changes

After the change of Dogfalo#6313, the weird underline appears on the input field. This PR fixes the problem while preserving the behavior of the browser-default class.

Screenshots (if appropriate) or codepen:

Original ( https://materializecss.com/chips.html )

image

Current

image

After this change

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though the margin of the input field differs from the original, I feel it is cool.

we could also do margin: 0 !important. But in the official guide also have similiar margin. So perhaps it's fine... or maybe just delete the margin rule in .chips .input? 😅

What do you guys think about this? @materializecss/members

@Pierstoval
Copy link

I'd rather find a way to not use !important when possible indeed :p

@nekonenene
Copy link
Author

@Pierstoval I think so, I'll try later. But it might be difficult without any breaking change...

@nekonenene
Copy link
Author

@Pierstoval @Smankusors
Although the CSS selector is dirty, I managed to fix without !important and update the description of this PR.

@DanielRuf DanielRuf merged commit bf71480 into materializecss:v1-dev Sep 23, 2020
@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: chips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants