Skip to content

Conversation

Jerit3787
Copy link
Member

@Jerit3787 Jerit3787 commented Dec 21, 2022

fix #323

Proposed changes

This pull request fixes issue #323 which navbar on the docs page not setting the list as active. I have fixed the page variable for Feature Discovery and everything works as expected

Screenshots (if appropriate) or codepen:

Before - Preview
image

After - Preview
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io merged commit ced14a5 into materializecss:main Jan 20, 2023
@Jerit3787 Jerit3787 deleted the fix-docs branch January 20, 2023 16:25
@wuda-io
Copy link
Member

wuda-io commented Jan 21, 2023

Thanks for your contribution, I invited you as a member.

@Jerit3787
Copy link
Member Author

Thanks for the invite! Truly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeatureDiscovery item in the navigation menu of the docs is not highlighted

2 participants