Skip to content

Conversation

nekonenene
Copy link

@nekonenene nekonenene commented Sep 19, 2020

Proposed changes

Added a description of how to build. It will help many developers who wants to get the latest materialize.css or materialize.js.

I'm not good at English, so please fix more natural if you feel something wrong.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the version changes in package.json.

@nekonenene nekonenene force-pushed the update_readme_about_build branch from 4f547dd to 1357bb2 Compare September 20, 2020 18:07
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Sep 21, 2020
@DanielRuf
Copy link

hmm I got what newver arg means, but how about oldver? Doesn't seem to affect anything? 😕

@Smankusors oldver is the old version string that is replaced by gulp-replace, just a simple find and replace. We could make it optional in the future by reading package.json and what I like is also yarn with its version --minor command.

@Smankusors Smankusors merged commit 733cf40 into materializecss:v1-dev Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants