-
-
Notifications
You must be signed in to change notification settings - Fork 107
Use the new issue form feature (a new type of issue template) #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Heya @materializecss/members-write-access is someone available to free some time to review my proposals ? |
Pinging @materializecss/members too. Anyone can do a PR review. So everyone feel free to give feedback. Someone else or I can do the merge then. |
Can you rename "general issue" to "improvement". It is good to encourage users to provide code. This codepen is linked to your user. What happens when you close your account? I dont think this is neccessary, because often we only have screenshots or videos. |
Agree
We do need to encourage users to provide code, and having a fresh codepen template will help this. About the account, I agree this is not very good to have a personal account. How about using this anonymous jsfiddle instead: https://jsfiddle.net/1es0zhaf/ In which we will update the template link at each update.
We may remove the "live example" input field, and ask instead to provide a link to a codepen, like the current issue template / improvement template WDYT ? |
I am not so familiar with codepen or jsfiddle. For a bug-issue the idea is very good. But i have to look at it in more detail how this works out in the long term. But we should give it a try and then improve over time. The improvement-issue doesnt need the code-input. Here we could encourage the user to link references or upload concept images or screenshots. Also the existing-bug section could be removed here. If you adapt this things, I agree to merge. |
I think we should mention "I have searched for duplicate or closed issues." in the first line so that the user don't waste time filling it out, and it turns out there's already existing one 🤔 |
Hello @wuda-io I applied your suggestions. Same for @Smankusors in which I renamed the "general issue" template into "improvement". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes
Fixes #296.
Replaces the current issue template by 2 forms (bug report, general issue)
Screenshots (if appropriate) or codepen:
Live example : https://github.com/LoganTann/materialize/issues/new/choose
👇 Screenshots
Taken before the last commit that fixed some typos.
Types of changes
Checklist: