Skip to content

Conversation

LoganTann
Copy link

Proposed changes

Fixes #296.

Replaces the current issue template by 2 forms (bug report, general issue)

image

Screenshots (if appropriate) or codepen:

Live example : https://github.com/LoganTann/materialize/issues/new/choose

👇 Screenshots

Taken before the last commit that fixed some typos.

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@LoganTann LoganTann requested a review from a team October 22, 2022 18:01
@LoganTann
Copy link
Author

Heya @materializecss/members-write-access is someone available to free some time to review my proposals ?

@DanielRuf
Copy link

Pinging @materializecss/members too. Anyone can do a PR review. So everyone feel free to give feedback.

Someone else or I can do the merge then.

@wuda-io
Copy link
Member

wuda-io commented Oct 24, 2022

Can you rename "general issue" to "improvement".
Because me as user doesnt know what is ment by general. I think we should seperate bugs and improvements

It is good to encourage users to provide code. This codepen is linked to your user. What happens when you close your account? I dont think this is neccessary, because often we only have screenshots or videos.

@LoganTann
Copy link
Author

Can you rename "general issue" to "improvement".

Agree

This codepen is linked to your user. What happens when you close your account?

We do need to encourage users to provide code, and having a fresh codepen template will help this.

About the account, I agree this is not very good to have a personal account.

How about using this anonymous jsfiddle instead: https://jsfiddle.net/1es0zhaf/

In which we will update the template link at each update.

I dont think this is neccessary, because often we only have screenshots or videos.

We may remove the "live example" input field, and ask instead to provide a link to a codepen, like the current issue template / improvement template

WDYT ?

@wuda-io
Copy link
Member

wuda-io commented Oct 24, 2022

I am not so familiar with codepen or jsfiddle. For a bug-issue the idea is very good. But i have to look at it in more detail how this works out in the long term. But we should give it a try and then improve over time.

The improvement-issue doesnt need the code-input. Here we could encourage the user to link references or upload concept images or screenshots. Also the existing-bug section could be removed here. If you adapt this things, I agree to merge.

@Smankusors
Copy link
Member

I think we should mention "I have searched for duplicate or closed issues." in the first line so that the user don't waste time filling it out, and it turns out there's already existing one 🤔

@LoganTann
Copy link
Author

Hello @wuda-io I applied your suggestions. Same for @Smankusors in which I renamed the "general issue" template into "improvement".

8ca2976

Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spongebob Many Thumbs

@Smankusors Smankusors merged commit c549b8c into materializecss:main Oct 29, 2022
@Smankusors Smankusors added the meta Issues with the project itself or our GitHub repository. label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues with the project itself or our GitHub repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve issues templates using github forms

4 participants