-
-
Notifications
You must be signed in to change notification settings - Fork 107
Update husky version #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update husky version #294
Conversation
What is package-lock.json for? Is it also needed to add in some Commits / PRs or should we add it to gitignore? |
package-lock.json is the lockfile generated by npm. Please always commit changes in there so all contributors have the same dependency versions. Endusers only get package.json because lockfiles are filtered on npmjs and not for consumers (and not read when part of node_modules). |
OK, I added the package-lock file and also ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
I will merge it and try that.
The postinstall should only run husky when it exists, as it is a devDependency. Upgrading on a regular environment is now broken: npm ERR! command failed |
Hi @rdevroede, we just have to make a new release. See https://github.com/materializecss/materialize/commits/main/package.json. Can someone handle this @materializecss/maintainers? |
I will try to do a new release 1.2.1 |
Proposed changes
The Commit-Message was not checked properly for many contributers, due to an old or outdated version of Husky and Commitlint. I updated the package.json File and added a required Commitlint-File. It works now on my machine, i re-installed node_modules with the new packege.json File and it works now. I hope this prevents future issues with it.
Screenshots (if appropriate) or codepen:
Types of changes
Updated the version of Husky and Commitlint. Also tested on a windows machine.
Checklist: