Skip to content

Conversation

wuda-io
Copy link
Member

@wuda-io wuda-io commented Oct 20, 2022

Proposed changes

The Commit-Message was not checked properly for many contributers, due to an old or outdated version of Husky and Commitlint. I updated the package.json File and added a required Commitlint-File. It works now on my machine, i re-installed node_modules with the new packege.json File and it works now. I hope this prevents future issues with it.

Screenshots (if appropriate) or codepen:

grafik

Types of changes

Updated the version of Husky and Commitlint. Also tested on a windows machine.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io added the bug Something isn't working label Oct 20, 2022
@wuda-io
Copy link
Member Author

wuda-io commented Oct 20, 2022

What is package-lock.json for? Is it also needed to add in some Commits / PRs or should we add it to gitignore?

@wuda-io wuda-io requested a review from a team October 20, 2022 20:10
@DanielRuf
Copy link

DanielRuf commented Oct 20, 2022

package-lock.json is the lockfile generated by npm. Please always commit changes in there so all contributors have the same dependency versions.

Endusers only get package.json because lockfiles are filtered on npmjs and not for consumers (and not read when part of node_modules).

@wuda-io
Copy link
Member Author

wuda-io commented Oct 21, 2022

OK, I added the package-lock file and also ran npm update on it. Is this ok?

Copy link

@LoganTann LoganTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

I will merge it and try that.

@LoganTann LoganTann merged commit e17d0c0 into materializecss:main Oct 22, 2022
@LoganTann
Copy link

image

works well, thanks for the contribution !

@Smankusors Smankusors added the meta Issues with the project itself or our GitHub repository. label Nov 19, 2022
@rdevroede
Copy link

The postinstall should only run husky when it exists, as it is a devDependency. Upgrading on a regular environment is now broken:

npm ERR! command failed
npm ERR! command sh -c husky install
npm ERR! sh: 1: husky: not found

@DanielRuf
Copy link

Hi @rdevroede,

we just have to make a new release. See https://github.com/materializecss/materialize/commits/main/package.json.

Can someone handle this @materializecss/maintainers?

@Smankusors Smankusors added bug Something isn't working and removed bug Something isn't working labels Dec 12, 2022
@wuda-io wuda-io mentioned this pull request Dec 12, 2022
@wuda-io
Copy link
Member Author

wuda-io commented Dec 12, 2022

Can someone handle this @materializecss/maintainers?

I will try to do a new release 1.2.1

@wuda-io wuda-io deleted the fix-husky-commitlint branch February 7, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues with the project itself or our GitHub repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants