Skip to content

fix(placeholder images): replace placehold.it with placeholder.com #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

fix(placeholder images): replace placehold.it with placeholder.com #291

merged 1 commit into from
Oct 11, 2022

Conversation

t-moennich
Copy link

fix #251

Proposed changes

It seems that placehold.it has been cancelled. To get rid of the errors, I changed all to the matching API of placeholder.com

Screenshots (if appropriate) or codepen:

2022-10-10 13_43_54-NVIDIA GeForce Overlay DT

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@t-moennich
fix(placeholder images): replace placehold.it with placeholder.com
ff29d11 
It seems that placehold.it has been cancelled. To get rid of the errors I changed all to the
matching API of placeholder.com

fix materializecss#251
Smankusors
Smankusors approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Smankusors Smankusors merged commit d694828 into materializecss:main Oct 11, 2022
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Oct 11, 2022
@Smankusors
Copy link
Member

btw I also invited you as the member of materializecss. Welcome! 🎉

@t-moennich t-moennich deleted the fix/replace-placeholdit-with-placeholdercom branch October 11, 2022 20:46
@Smankusors Smankusors added the hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smankusors Smankusors Smankusors approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(minor) broken placeholder link in Autocomplete doc page
2 participants
@t-moennich @Smankusors