Skip to content

Conversation

ajoygphilip
Copy link

Break up the first para, make minor changes, and place the contents under relevant sub-topics. Add definition to floating action buttons based on https://material.io/archive/guidelines/components/buttons.html#.

Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@LoganTann LoganTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good.

@LoganTann
Copy link

However, the pipeline fails due to your commit message. You need to change it.

do git commit --amend -m "doc(button-content): Update and rearrange content for readability "

then git push -f

@LoganTann
Copy link

Also, more personal question, did you make this contribution for the hacktoberfest?

@ajoygphilip ajoygphilip force-pushed the button-documentation-updates branch from 35a57e5 to 4c96304 Compare October 3, 2022 15:15
@ajoygphilip
Copy link
Author

However, the pipeline fails due to your commit message. You need to change it.

do git commit --amend -m "doc(button-content): Update and rearrange content for readability "

then git push -f

Done. Thank you so much for walking me through.

Copy link

@LoganTann LoganTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@materializecss/maintainers I don't have the right to run the CI. Can someone take care of it in order to get this validated for merge ?

@Smankusors
Copy link
Member

Smankusors commented Oct 3, 2022

oh uh, it should be lower case after colon, and the type should be docs

so the commit message should be docs(button-content): update and rearrange content for readability

you can validate it with https://commitlint.io btw

@ajoygphilip ajoygphilip force-pushed the button-documentation-updates branch from 4c96304 to 4238782 Compare October 4, 2022 05:10
@ajoygphilip
Copy link
Author

oh uh, it should be lower case after colon, and the type should be docs

so the commit message should be docs(button-content): update and rearrange content for readability

you can validate it with https://commitlint.io btw

Changed.

@DanielRuf
Copy link

@materializecss/maintainers I don't have the right to run the CI. Can someone take care of it in order to get this validated for merge ?

I did now.

@LoganTann
Copy link

@DanielRuf I don't have the rights to merge, may you review this and merge it once it's approved ?

@DanielRuf
Copy link

@LoganTann now you should be able to merge. If not, please let me know.

Bildschirmfoto 2022-10-04 um 22 59 12

Bildschirmfoto 2022-10-04 um 22 59 56

@LoganTann LoganTann merged commit 0006c36 into materializecss:main Oct 4, 2022
@LoganTann
Copy link

all good @DanielRuf, thanks you !

@DanielRuf
Copy link

hi @ajoygp,

thanks for your contribution, which is very welcome.

We have invited you now as member of the materialize org. Happy to have you on board.

image

@LoganTann LoganTann added the hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event label Oct 7, 2022
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants