Skip to content

Conversation

rmehner
Copy link

@rmehner rmehner commented Sep 22, 2022

Proposed changes

Makes striped work for tables again, which is a fix for #279. Bug is described within the issue.

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rmehner
Copy link
Author

rmehner commented Sep 22, 2022

@Smankusors Force pushed with proper commit message :)

@rmehner
Copy link
Author

rmehner commented Sep 26, 2022

@Smankusors Makes sense. I just restored the old rules, but it makes sense to reduce nesting :) Applied your suggestion.

@rmehner rmehner force-pushed the bugfixes/fix-table-striped branch from 1a383f2 to 71886a7 Compare September 27, 2022 09:49
@rmehner
Copy link
Author

rmehner commented Sep 27, 2022

@Smankusors fixed commit messages to make commit lint happy again 😓

@Smankusors Smankusors merged commit fc615ac into materializecss:main Sep 27, 2022
@rmehner rmehner deleted the bugfixes/fix-table-striped branch September 27, 2022 14:29
@Smankusors
Copy link
Member

thanks for your contribution!

also, I invited you as the member of materializecss. Welcome 🎉

@Smankusors Smankusors added the bug Something isn't working label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants