Skip to content

Conversation

Smankusors
Copy link
Member

Proposed changes

In this PR, I would like to propose a documentation for the maintainers. So that if I'm not available and/or someone else would like to move this forward in the future, at least we will know what should be done.

In this document, I added 3 sections, which is labels, releasing a new version, and generating a changelog.

Let me know what do you think about this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors Smankusors added the meta Issues with the project itself or our GitHub repository. label Apr 23, 2022
@Smankusors Smankusors requested a review from a team April 23, 2022 16:59
Copy link

@LoganTann LoganTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a second review from someone who haves a push access to this repo

  make sure that on the next release to update this variable
@Smankusors
Copy link
Member Author

btw I just realized the existence of M.version... I think for someone who will release the next version, please make sure to update this variable 😅

might need to fix the grunt release script too 🤔

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the process

@jshster
Copy link

jshster commented Apr 24, 2022

Thanks so much for doing this. Will be reading through ASAP.

@wuda-io
Copy link
Member

wuda-io commented May 12, 2022

What is missing to do the merge?

@Smankusors Smankusors merged commit 42468a3 into materializecss:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues with the project itself or our GitHub repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants