Skip to content

Conversation

Smankusors
Copy link
Member

Proposed changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors Smankusors requested a review from a team January 10, 2022 02:01
@Smankusors Smankusors self-assigned this Jan 10, 2022
@Smankusors
Copy link
Member Author

I think we should edit the existing GitHub action to commit the docs to the https://github.com/materializecss/materializecss.github.io instead of to the docs branch... Wdyt? @materializecss/members

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but does this fix the Templates or only the 404 Page?
Greets

@DanielRuf
Copy link

@wuda-io to me it looks like it does: 6a2c628

Did you test it locally?

@Smankusors
Copy link
Member Author

@wuda-io to me it looks like it does: 6a2c628

Did you test it locally?

yeah, and there's an additional commit 2d0a82e to fix the styling if the user tries to navigate to /materialize/404/not/found.

In the local env it didn't show the 404.html, but it should appear normally in the github.io.

@DanielRuf DanielRuf merged commit 026fe0d into materializecss:main Jan 11, 2022
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Apr 7, 2022
DyegoCosta pushed a commit to DyegoCosta/materialize that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templates won't load
3 participants