Skip to content

Conversation

MadhaviMandalia
Copy link
Member

Proposed changes

Removed icon list from the page and change the text with the relevant link which is Search Google's Icons

Screenshots:

img

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MadhaviMandalia MadhaviMandalia mentioned this pull request Dec 31, 2021
@DanielRuf
Copy link

@MadhaviMandalia all fine so far. But commitlint check does not succeed.

Please change the commit message from

docs:Icon table removed, rephrase the Icons description #225

to

docs: remove icon table, rephrase the icons description #225

@MadhaviMandalia
Copy link
Member Author

@DanielRuf Thanks 😃

@DanielRuf DanielRuf merged commit f6774ee into materializecss:main Jan 4, 2022
@DanielRuf
Copy link

@MadhaviMandalia thanks for your contribution to materializecss.
Welcome to the materializecss project.

I have sent you an invite as member of https://github.com/materializecss. Also there is just one small change needed:
55ccfa4#commitcomment-62917089

Let us know if you want to do this small change or if someone else can do it.

@MadhaviMandalia
Copy link
Member Author

MadhaviMandalia commented Jan 5, 2022

Hello @DanielRuf ,
I will raise another PR for this issue. Where should I put the link on the page?
Currently it is on the right hand side of the page under Usage.

Thanks & Regards.

@DanielRuf
Copy link

DanielRuf commented Jan 5, 2022

@MadhaviMandalia

We use Google Material Icons by Google. They provide a searchable list (which we do not include in the documentation here), which will also show you the relevant icon names for the CSS classes.

You can link these two words like

<a href="...">searchable list</a>

@MadhaviMandalia
Copy link
Member Author

Oops I thought we had to implement this somewhere on the tutorial or something I didn't look at the description 😄

@Smankusors Smankusors added the documentation Improvements or additions to documentation label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants