feat(autocomplete): add custom sort option #190
Conversation
BREAKING CHANGE: renamed sortFunction to compareFunction
|
Currently The v2-dev branch is a bit behind on some critical things (mainly jade-> pug and the GitHub actions fix). It'll be rebased onto main and then this pr will need updating I suppose. Good spot 😊 |
| data: defaultData, | ||
| filterFunction: function (key_string, filter_string) { | ||
| compareFunction: function (key_string, filter_string) { | ||
| return true; |
There was a problem hiding this comment.
I think returning true for a compareFunction is a bit weird. But it made sense for a thing called filterFunction. Don't you think?
Why did this line change?
There was a problem hiding this comment.
To my knowledge, filterFunction never existed, this is the only reference to it I can find. I'd consider using the name over compareFunction as I agree that it makes a bit more sense. Filter function to me, however does imply that things would be removed from the results but that's not the case. Maybe @samschurter could give some insight as they introduced this line (infact the whole file).
|
Any updates about this PR ? |
|
Can this PR be closed? |
|
This will be obsolete with #261 |
Remake of #116. Also renamed sortFunction to compareFunction (Closes #115)
Proposed changes
Currently you can specify a custom "sortFunction" but this only controls which element wins in a 1v1 matchup, not how the matchups are made (Currently just uses array.sort). Adding this would allow end users to use libraries such as fuse.js to do more complex sorting and make results more accurate.
Types of changes
Checklist: