Skip to content

Conversation

warrenrodrigues
Copy link

@warrenrodrigues warrenrodrigues commented Jul 24, 2021

Proposed changes

  • Use a single message container to inform user when text is copied.
  • Copy text without creating a textarea. Currently, the textarea appears at the bottom of the page. Screenshot below.

Getting Started - Materialize - materializecss github io

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DanielRuf
Copy link

Do you want to make a review? That would be awesome @christinavoudouris.

@warrenrodrigues warrenrodrigues requested a review from a user July 24, 2021 19:47
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warrenrodrigues this looks great! I'm glad someone was able to improve the code as I couldn't find a more eloquent solution. I tested it out in Codepen just now and agree that's optimal.

@warrenrodrigues
Copy link
Author

@christinavoudouris Thank you. Good idea to offer an option to copy the code snippet.

@DanielRuf
Copy link

Thank you both for the great work!

@DanielRuf DanielRuf merged commit 83a8c02 into materializecss:v1-dev Jul 24, 2021
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants