Skip to content

Fix bug by adding missing classes in img element in select component #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix bug by adding missing classes in img element in select component #110

merged 1 commit into from
Apr 27, 2021

Conversation

Talagozis
Copy link

Proposed changes

It fixes the Dogfalo#5797 issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Talagozis
Copy link
Author

Previous PR: Dogfalo#6152

@DanielRuf DanielRuf requested a review from a team April 27, 2021 11:25
wuda-io
wuda-io approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DanielRuf DanielRuf merged commit 96ee7bf into materializecss:v1-dev Apr 27, 2021
@DanielRuf
Copy link

Hi @Talagozis,

thanks for your cobntribution.
I have invited you to the @materializecss org and added you to the members group.

@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuda-io wuda-io wuda-io approved these changes

+1 more reviewer

@DanielRuf DanielRuf DanielRuf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Talagozis @DanielRuf @wuda-io @Smankusors