Clicking outside of a carousel image breaks the carousel with the NoWrap option

[LoganTann]

The original issue is here Dogfalo#6459 and wasn't fixed by 1.1.0-alpha. No PR were made, but we describe why the issue happens and what code have to be changed : all we need is a volounteer who can fork and create the PR.

Here is an issue with a better English and explanations.

Expected Behavior

• In a carousel with NoWrap option, we can navigate to right or left by clicking at the correct side of the carousel, as long as we don't click on the carousel image.
• Clicking :
  • at left when the current selected item is the first should move to the last item
  • at right when the current selected item is the last should move to the first item

Current Behavior

Clicking :

• at left when the current selected item is the first
• at right when the current selected item is the last

will break the carousel display (clicking inside a carousel item fixes the display) and also the "navigation by clicking right or left side" feature (to make it work again, we have to reload the page).

Possible Solution

See comments starting from : Dogfalo#6459 (comment)

We've found a both the source and the solution to the issue, but we haven't made a pull request. Thus, this should be easy to fix.

Steps to Reproduce

See the description above, or open the codepen link below and follow the instructions

Context (of original issue)

Carousel are often used in my project to store a short list of book/albums and display their metadata depending on the current selected item.

Your Environment

• Version used: 1.1.0
• Browser Name and version: Firefox 92.0
• Operating System : Windows 10
• Link to your project :
  • With 1.0.0 : https://codepen.io/shinprog/pen/oNNgJee
  • With 1.1.0-alpha (same but different css and script URLs) : https://codepen.io/shinprog/pen/RwgVJwr

[Smankusors]

Hey, thanks for the solution 😃

I do wonder, why you don't create a PR? I do read that you don't have a developement environment. You don't have the node installed?

[LoganTann]

I do wonder, why you don't create a PR? I do read that you don't have a developement environment. You don't have the node installed?

At the time I created the issue, I hadn't a development environment, and I also didn't know how to properly contribute to a github project
Now I can do it, but I don't know if I can get enough free time this month to create a PR ^^ That's why I'm asking if there is any volunteer to make it.

[DanielRuf]

Now I can do it, but I don't know if I can get enough free time this month to create a PR ^^ That's why I'm asking if there is any volunteer to make it.

No hurry =) Anyone who wants to help here @materializecss/members?

[LoganTann]

finally, I managed to patch the issue. waiting PR #187 for approval or revisions

[LoganTann]

Merged, I'm closing this issue.

Sorry, I took too long to review, thanks for the PR and everyone that reviewed this PR 👍
Anyway, I sent an invitation to you to join the @materializecss/members team. Welcome 🎉
No worries, It's cool that my PR have been accepted.

I'm very glad to join the community as a contributor, delighted 👋 !
I used Materialize since it's beta version (2017), and even if it starts to become old (no good support for frameworks, bad css practices inside the code) I still use it for most of my projects to create well-designed websites faster.
I manage too much projects in my uni life, but I'll do my possible to help materialize to move forward