Skip to content

Fix screenshots path for IzzyOnDroid #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025
Merged

Conversation

mkalmousli
Copy link
Contributor

Hello @matan-h,

I've noticed that the new screenshots aren't shown on F-Droid clients (
And also not on the website):

I am not really sure why this happens, my guess is that the phoneScreenshots wasn't meant to be a symlink (or its for security? idk)..

Maybe its because fastlane/metadata/android/en-US/images/phoneScreenshots is a symlink to screenshots/result?

In this PR I simply reversed that so that fastlane/metadata/android/en-US/images/phoneScreenshots will be the actual directory and screenshots/result is the symlink.

Nothing else is changed.

…ymlink from screenshots/result to its new location
@mkalmousli
Copy link
Contributor Author

mkalmousli commented Jul 5, 2025

@matan-h
Copy link
Owner

matan-h commented Jul 6, 2025

Thats very cool. I've asked izzydroid the same question, and he replies to reverse the symlink direction too

Fastlane is only synced when a new release is pulled. And the direction of the symlink means we cannot manually trigger an "online sync" (handling symlinks via the Github API is a bit tricky, and thus we didn't implement it), so you'll have to wait until a new release is pulled together with a fresh clone of your repo. Would you switch the symlink direction (i.e. having the real files in fastlane, and link the screenshot result folder to that), we can manually trigger a "fastlane online sync", should it be urgent.

@matan-h matan-h merged commit cabde55 into matan-h:main Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants