Skip to content

Conversation

williamboman
Copy link
Member

@williamboman williamboman commented Aug 2, 2025

Comment on lines +6 to +8
"not": {
"required": ["supported_platforms"]
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that supported_platforms is not used for github sources - these already have the ability to express supported platforms so having this field as well would be redundant.

@williamboman williamboman requested a review from a team August 2, 2025 14:05
@williamboman
Copy link
Member Author

FWIW, tested on all package definitions in the core registry without errors.

find packages -type f | xargs -P10 -I{} ajv validate -d {} -c ajv-formats -s ~/dev/registry-schema/out/package.schema.json

@williamboman williamboman changed the title feat: add schema support for universal supported_platforms support feat: add schema support for universal supported_platforms support Aug 2, 2025
Copy link

@Conarius Conarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Conarius Conarius merged commit 1c0fd9e into main Aug 2, 2025
1 check passed
@Conarius Conarius deleted the feat/universal-supported-platforms branch August 2, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants