test_manager: Replace files atomically when committing #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly writing to the test case, write first to a temporary file and then rename it. This is atomic on popular file systems. Also refactor the code to have a dedicated fileutil helper, and cover it with unit tests.
|
After playing more with this, I've discovered the previous solution with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of directly writing to the test case, write first to a temporary file and then rename it. This is atomic on popular file systems.
Also refactor the code to have a dedicated fileutil helper, and cover it with unit tests. It'll make the upcoming support of directory inputs in #301 slightly cleaner.