Skip to content

Conversation

lespea
Copy link
Contributor

@lespea lespea commented Aug 13, 2025

golang/go#74462

I didn't update the go directive in go.mod.

Copy link
Owner

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I prefer not to update all dependencies blindly as that might introduce a security issue.

Ideally we only update the module that fixes the builds, any idea which one it is? Likely golang.org/x/mod or golang.org/x/tools or both.

@viceice
Copy link

viceice commented Aug 15, 2025

it's golang.org/x/tools

> go install github.com/marwan-at-work/mod/cmd/mod@latest 
1.035 go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.2
1.056 go: downloading github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673
1.193 go: downloading github.com/ProtonMail/go-crypto v0.0.0-20230426101702-58e86b294756
1.337 go: downloading github.com/google/go-querystring v1.1.0
1.477 go: downloading github.com/russross/blackfriday/v2 v2.1.0
1.606 go: downloading golang.org/x/sys v0.12.0
1.814 go: downloading golang.org/x/crypto v0.13.0
1.814 go: downloading github.com/cloudflare/circl v1.3.2
9.359 # golang.org/x/tools/internal/tokeninternal
9.359 /home/ubuntu/go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)

@marwan-at-work
Copy link
Owner

@viceice in that case do you mind just running go get golang.org/x/tools instead of the commit above? Thanks!

@viceice
Copy link

viceice commented Aug 15, 2025

sure, but not before Monday

@lespea
Copy link
Contributor Author

lespea commented Aug 18, 2025

Sorry I was away on vacation... just did go get golang.org/x/tools and tidy.

Copy link
Owner

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marwan-at-work marwan-at-work merged commit 7b2c142 into marwan-at-work:master Aug 18, 2025
@lespea
Copy link
Contributor Author

lespea commented Aug 18, 2025

@marwan-at-work can you please do a tag/release as well when you get a chance.

@uvegla
Copy link

uvegla commented Sep 4, 2025

+1 for releasing properly. The above issue broke some of our pipelines. Can use the v0.9.0 tag to get over it tho. Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants