-
-
Notifications
You must be signed in to change notification settings - Fork 1
Handle failed benchmarks #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix error if a benchmark has failed and has no `Statistics`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 84.68% 84.85% +0.17%
==========================================
Files 2 2
Lines 346 350 +4
Branches 79 83 +4
==========================================
+ Hits 293 297 +4
Misses 52 52
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Set the value to `NaN` to avoid it being serialized as `null`.
Handle `"NaN"` as a value in the benchmark data if a benchmark run fails. See martincostello/benchmarkdotnet-results-publisher#266.
Handle `"NaN"` as a value in the benchmark data if a benchmark run fails. See martincostello/benchmarkdotnet-results-publisher#266.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the benchmark publishing logic to handle cases where a benchmark fails and no Statistics are available.
- Introduces fallback values for benchmarks with missing Statistics in the publisher.
- Adds a failing benchmark test fixture and an associated test case to verify proper handling.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/fixtures/failing-benchmark/BenchmarkDotNet.Artifacts/results/TodoApp.OpenApiBenchmarks-report-github.md | Adds a new test fixture report for a failing benchmark scenario |
| src/BenchmarksPublisher.ts | Updates logic to use fallback values for missing Statistics in benchmarks |
| tests/main.test.ts | Adds a test case for the failing benchmark scenario |
Files not reviewed (3)
- tests/snapshots/main.test.ts.snap: Language not supported
- tests/fixtures/failing-benchmark.json: Language not supported
- tests/fixtures/failing-benchmark/BenchmarkDotNet.Artifacts/results/TodoApp.OpenApiBenchmarks-report-full-compressed.json: Language not supported
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Test bug fix from martincostello/benchmarkdotnet-results-publisher#266.
Fix error if a benchmark has failed and has no
Statistics.Found via martincostello/aspnetcore-openapi#231.