[ChordProParser] Not Recognizing Custom Sections, and other section-related issues

[edonv]

I've got a few feature requests relating to parsing different section types from ChordPro:

• Section labels support the following syntax {start_of_verse: label="Verse 1"}, not just {start_of_verse: Verse 1}. Currently ChordProParser doesn't like this and reads label="Verse 1" as the section label.
• Per the ChordPro spec, it's allowed to name a section anything, as long as the directive starts with start_of_ and end_of_. I use this a lot (i.e. start_of_pre_chorus), and because of this, ChordProParser just ignores the label altogether.
• I can't speak for the other formatters, but in my experience with HtmlTableFormatter, grid sections are rendered with the section label inline with its content. Is it possible to at least render the section label in the same way as other sections, separated?
  • Actually, it looks like HtmlDivFormatter does format the label, but it's still inline with the section content.
  • Additionally, it'd be nice if the . syntax (cells spacing) in grid sections could be rendered as separate table cells or something, like how it's rendered in ChordPro, but I'm not sure if that's possible with the way ChordSheetJS stores parsed songs.

See here for more details on this.

I'm sure I'll run into more things later, but this is it for now. I think most of this should be easily addable, no?

[edonv]

Oh, and I'll add that it seems both HTML formatters are adding a comma to the end of a line that has whitespace then a chord after the last word.

Example:

When you need[C#m]  an escape  [/C]

Screenshot:

[SamuMazzi]

Oh, and I'll add that it seems both HTML formatters are adding a comma to the end of a line that has whitespace then a chord after the last word.

I think this is relatd to #1409

[martijnversluis]

Hey @edonv. Thanks for your feedback! I created 3 separate issues and put them on the board.