Skip to content

Conversation

@papa99do
Copy link
Collaborator

@papa99do papa99do commented Oct 6, 2025

Change Summary

The temporary pagination RRF fix might make the pagination less stable for some data set. Revert the change now

Related Jira Ticket

Checklist

  • Tests have been added for changes
  • Documentation has been updated
  • Breaking changes are clearly identified
  • Python client changes linked or N/A

For new field types:

  • Tests cover score modifier usage of this new type
  • Test indexes updated to cover the new type for all APIs (add docs, search, partial update, etc.)

Note

Escapes special characters in typeahead queries, standardizes Vespa timeouts (incl. vector count queries) and HTTP client behavior, adds a metrics logger, and bumps version to 2.24.3 with corresponding tests.

  • Typeahead:
    • Escape special characters in tokens for YQL via Typeahead._escape_token(); apply to retrieval and ranking terms using CHARACTERS_TO_BE_ESCAPED_IN_VESPA.
    • Add unit/integration tests covering quotes/backslashes and mixed cases.
  • Vespa Client:
    • query() timeout param now optional (ms); always set Vespa timeout; configure httpx read timeout to be ≥ Vespa timeout + 1s and ≥ 5s; pass timeout to httpx.Client.post.
    • Tests ensure HTTP timeout config and that client doesn’t time out before Vespa; additional timeout-related cases.
  • Vector Count Queries:
    • Change timeout from '5s' to 5000 in structured_vespa_index and unstructured_vespa_index.
  • Logging:
    • Add metrics logger fixed at INFO; keep uvicorn.access level tied to root. Update tests.
  • Index Management Tests:
    • Adjust bootstrap migration flow to persist marqo config and remove version patching in one case.
  • Version:
    • Bump __version__ to 2.24.3.

Written by Cursor Bugbot for commit 4ba8de8. This will update automatically on new commits. Configure here.

@papa99do papa99do changed the base branch from mainline to releases/2.24 October 6, 2025 01:16
@papa99do papa99do requested review from farshidz and wanliAlex October 6, 2025 02:37
@papa99do papa99do merged commit 0bc7461 into releases/2.24 Oct 6, 2025
36 checks passed
@papa99do papa99do deleted the yihan/revert-pagination-fix branch October 6, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants