Skip to content

Approximate threshold search parameter #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 4, 2025

Conversation

farshidz
Copy link
Collaborator

@farshidz farshidz commented May 29, 2025

Change Summary

Expose Vespa's approximate threshold parameter for tensor and hybrid search.

py-marqo: marqo-ai/py-marqo#288
docs: https://github.com/marqo-ai/marqodocs/pull/437

Related Jira Ticket

https://s2search.atlassian.net/browse/MOSD-304

Checklist

  • Tests have been added for changes
  • Documentation has been updated
  • Breaking changes are clearly identified
  • Python client changes linked or N/A

For new field types:

  • [N/A] Tests cover score modifier usage of this new type
  • [N/A] Test indexes updated to cover the new type for all APIs (add docs, search, partial update, etc.)

@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 0812234 to 7f8f062 Compare May 29, 2025 01:14
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 64f0c42 to 998206a Compare May 29, 2025 01:41
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 998206a to 20fc8ff Compare May 29, 2025 01:41
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from dc653e0 to 1079b17 Compare June 2, 2025 02:08
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 1079b17 to 7201aa6 Compare June 2, 2025 03:28
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 06d2c8a to 113157f Compare June 2, 2025 04:46
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 769fd28 to 00f31bc Compare June 2, 2025 05:22
@farshidz farshidz marked this pull request as ready for review June 2, 2025 06:28
@farshidz farshidz changed the title Farshid/approximate threshold Approximate threshold search parameter Jun 2, 2025
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from bdbe289 to 1238cf0 Compare June 2, 2025 07:23
@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 1238cf0 to 02a40bf Compare June 2, 2025 07:24
@papa99do
Copy link
Collaborator

papa99do commented Jun 3, 2025

Why did it change the imports in all tests? Can we have a separate PR for this refactoring?

papa99do
papa99do previously approved these changes Jun 3, 2025
Copy link
Collaborator

@papa99do papa99do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidz farshidz force-pushed the farshid/approximate-threshold branch from 5d0b20e to defed98 Compare June 3, 2025 12:51
@farshidz farshidz merged commit 35e5323 into mainline Jun 4, 2025
29 of 31 checks passed
@farshidz farshidz deleted the farshid/approximate-threshold branch June 4, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants