-
Notifications
You must be signed in to change notification settings - Fork 212
Approximate threshold search parameter #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0812234
to
7f8f062
Compare
64f0c42
to
998206a
Compare
998206a
to
20fc8ff
Compare
dc653e0
to
1079b17
Compare
1079b17
to
7201aa6
Compare
06d2c8a
to
113157f
Compare
769fd28
to
00f31bc
Compare
bdbe289
to
1238cf0
Compare
1238cf0
to
02a40bf
Compare
Why did it change the imports in all tests? Can we have a separate PR for this refactoring? |
papa99do
reviewed
Jun 3, 2025
...s/unit_tests/marqo/core/structured_vespa_index/test_structured_vespa_index_to_vespa_query.py
Show resolved
Hide resolved
papa99do
previously approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5d0b20e
to
defed98
Compare
papa99do
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Expose Vespa's approximate threshold parameter for tensor and hybrid search.
py-marqo: marqo-ai/py-marqo#288
docs: https://github.com/marqo-ai/marqodocs/pull/437
Related Jira Ticket
https://s2search.atlassian.net/browse/MOSD-304
Checklist
For new field types: