Adopt new headless mode by default #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marp CLI is using the classic headless known as
shellmode in current Puppeteer.https://developer.chrome.com/blog/chrome-headless-shell
The headless shell will become to remove from the browser binary in the last of 2024, so we have to update the headless mode into the current. Marp CLI had been able to choose the new headless mode via
PUPPETEER_HEADLESS_MODE=newenv (#508), and now it will be used to revert into the classic headlessshellviaPUPPETEER_HEADLESS_MODE=old,legacy, orshell.