Skip to content

Allow enabling LayoutNG while PDF conversion via CHROME_LAYOUTNG_PRINTING env #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Allow enabling LayoutNG while PDF conversion via CHROME_LAYOUTNG_PRINTING env #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c233286
Allow to enable LayoutNG printing by setting CHROME_LAYOUTNG_PRINTING…
yhatt Aug 11, 2022
4a5d4f5
Add test for CHROME_LAYOUTNG_PRINTING env
yhatt Aug 11, 2022
5f1977f
Remove debug logging
yhatt Aug 11, 2022
675428a
[ci skip] Update CHANGELOG.md
yhatt Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Added

- Allow enabling [LayoutNG](https://www.chromium.org/blink/layoutng/) while PDF conversion via `CHROME_LAYOUTNG_PRINTING` env ([#469](https://github.com/marp-team/marp-cli/pull/469))

### Changed

- Upgrade Marp Core to [v3.3.1](https://github.com/marp-team/marp-core/releases/v3.3.1) ([#468](https://github.com/marp-team/marp-cli/pull/468))
Expand Down
6 changes: 6 additions & 0 deletions src/utils/puppeteer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@ export const generatePuppeteerLaunchArgs = async () => {
// Enable DocumentTransition API
if (!process.env.CI) args.add('--enable-blink-features=DocumentTransition')

// LayoutNG Printing
if (process.env.CHROME_LAYOUTNG_PRINTING)
args.add(
'--enable-blink-features=LayoutNGPrinting,LayoutNGTableFragmentation'
)

// Resolve Chrome path to execute
if (executablePath === false) {
let findChromeError: Error | undefined
Expand Down
13 changes: 13 additions & 0 deletions test/utils/puppeteer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,19 @@ describe('#generatePuppeteerLaunchArgs', () => {
}
})

it('enables LayoutNGPrinting and LayoutNGTableFragmentation if defined CHROME_LAYOUTNG_PRINTING environment value', async () => {
try {
process.env.CHROME_LAYOUTNG_PRINTING = '1'

const args = await puppeteerUtils().generatePuppeteerLaunchArgs()
expect(args.args).toContain(
'--enable-blink-features=LayoutNGPrinting,LayoutNGTableFragmentation'
)
} finally {
delete process.env.CHROME_LAYOUTNG_PRINTING
}
})

describe('with CHROME_PATH env in macOS', () => {
let originalPlatform: string | undefined

Expand Down