Fixed typescript types #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjon
reviewed
Aug 3, 2020
| from(...params: any[]): Promise<void>; | ||
| getFromLocation(address: string): Promise<any>; | ||
| getFromLatLng(lat: number, lng: number): Promise<any>; | ||
| static init(apiKey: string, options: Object): void; |
There was a problem hiding this comment.
@snaquaye shouldn't options be optional ? like in the docs
static init(apiKey: string, options?: Object): void;
iamjon
reviewed
Aug 3, 2020
| init(apiKey: string, options: Object): void; | ||
| isInit(): boolean; | ||
| setApiKey(API_KEY: string): void; | ||
| from(...params: any[]): Promise<void>; |
There was a problem hiding this comment.
from doesn't return void, it returns a google geocoding response like so
https://developers.google.com/maps/documentation/geocoding/overview#GeocodingResponses or it throws an error.
What I did locally was create an interface that contains the geocoding response like so
interface geocodingResponse { plus_code: {compound_code: string, global_code: string} results: Array; status: string; }
and changed the declartion to:
static from(...params: any[]): Promise<geocodingResponse>;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.