Skip to content

fix: class/id shorthand parsing improvements #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Jul 19, 2025

  • ensures shorthand classes are consistently output before normal classes when concatenated
  • better preserves source mapping information when merging shorhand and literal class value

Copy link

changeset-bot bot commented Jul 19, 2025

🦋 Changeset detected

Latest commit: d0b776c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (aa4344d) to head (d0b776c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2743      +/-   ##
==========================================
+ Coverage   87.99%   88.00%   +0.01%     
==========================================
  Files         362      362              
  Lines       44167    44176       +9     
  Branches     3374     3374              
==========================================
+ Hits        38863    38876      +13     
+ Misses       5279     5275       -4     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey merged commit 5b3ca5c into main Jul 19, 2025
11 checks passed
@DylanPiercey DylanPiercey deleted the shorthand-class-id-improvements branch July 19, 2025 22:27
@github-actions github-actions bot mentioned this pull request Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant