Skip to content

Demo Page: Give user feedback when "options" is not valid JSON. #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Demo Page: Give user feedback when "options" is not valid JSON. #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a95b5bc
Give user feedback when options is not parsing.
aprotim Oct 18, 2018
edaddac
Options input shouldn't be resizeable
aprotim Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/demo/demo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ header h1 {
box-sizing: border-box;
}

#options {
resize: both;
}

.pane, .inputPane {
margin-top: 5px;
padding: 0.6em;
Expand All @@ -65,3 +61,8 @@ header h1 {
#preview iframe {
flex-grow: 1;
}

#options.badParse {
border-color: red;
background-color: #FEE
}
2 changes: 2 additions & 0 deletions docs/demo/demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ function checkForChanges() {
var optionsString = $optionsElem.value || '{}';
var newOptions = JSON.parse(optionsString);
options = newOptions;
$optionsElem.classList.remove('badParse');
} catch (err) {
$optionsElem.classList.add('badParse');
}

var lexed = marked.lexer($markdownElem.value, options);
Expand Down