-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Closed
Description
Follow-up from #1020 (comment)
I just removed the node_modules directory and run npm update
on a fresh working copy.
This is what I get:
$ npm up
npm WARN deprecated [email protected]: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated [email protected]: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
[email protected] /home/federico/marked
├── [email protected]
├── [email protected]
├── UNMET PEER DEPENDENCY eslint-plugin-import@>=2.2.0
├── [email protected]
├── UNMET PEER DEPENDENCY eslint-plugin-promise@>=3.5.0
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]
npm WARN [email protected] requires a peer of eslint-plugin-import@>=2.2.0 but none was installed.
npm WARN [email protected] requires a peer of eslint-plugin-promise@>=3.5.0 but none was installed.
I think this needs some checking.
First of all, I think peerdependencies need to be explicitly installed alongside their dependants, so I'm gonna add .eslint-plugin-import
and eslint-plugin-promise
to #1020`
This was taken care of by @UziTech in Feder1co5oave#1. Thanks!
Here's the updated section in package.json
:
"devDependencies": {
"eslint": "^4.15.0",
"eslint-config-standard": "^11.0.0-beta.0",
"eslint-plugin-import": "^2.8.0",
"eslint-plugin-node": "^5.2.1",
"eslint-plugin-promise": "^3.6.0",
"eslint-plugin-standard": "^3.0.1",
"front-matter": "^2.3.0",
"glob-to-regexp": "0.3.0",
"gulp": "^3.8.11",
"gulp-concat": "^2.5.2",
"gulp-uglify": "^1.1.0",
"markdown": "*",
"markdown-it": "*",
"showdown": "*"
},
Other concerns I might need some help with:
-
eslint-config-standard
is a beta version, should we need to worry about this? -
gulp-util
is a deprecated package.gulp
is its dependant. It seems that gulp does not depend on gulp-util since version 4.which is still alpha. What to do?gulp-uglify
depends on it too. Update this too? I already updatedGulpfile.js
to work with v4, so that would be taken care of. -
graceful-fs
needs to be updated. This can be done updatinggulp
to 4.0.0 -
minimatch
needs to be updated. Same as above, gulp 4.0.0 does this. -
gulp
is used only as a build system to minify the source intomarked.min.js
, via the plugingulp-uglify
. Can't we useuglify-js
directly?gulp
comes with a lot of dependencies -
markdown.js
,markdown-it
andshowdown
are listed as devDependencies because we use them to perform comparative benchmarking. Should we bind at least the major version to make sure API don't change over time and break our benching script? In bench against commonmark instead of showdown #1019 I specified version0.x
, for example. Fixed in bench against commonmark instead of showdown #1019 - remove gulp in favor of using uglify-js CLI. Fixed in Use uglifyjs CLI instead of Gulp to minify #1046
Gulp was brought in in #553 with the hope that it would become more useful over time. In my opinion we should just depend on uglify-js and use it as a CLI in the build
npm script.
Metadata
Metadata
Assignees
Labels
No labels