This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Fix tweet sorting #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@v0ctor This change breaks the checking of MIN_DATE, MAX_DATE parameters, see the comment in the code. |
xPaw
reviewed
Nov 16, 2024
app.ts
Outdated
| let ad = new Date(a.tweet.created_at).getTime(); | ||
| let bd = new Date(b.tweet.created_at).getTime(); | ||
| return ad - bd; | ||
| return parseInt(a.tweet.id) - parseInt(b.tweet.id); |
There was a problem hiding this comment.
Tweet ids are too big for JS, so don't parse them:
parseInt('1857820252878323986')
1857820252878324000
|
Thanks for the feedback! Both things work properly now with the latest commit (tested with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sorts tweets by ID instead of date.
It is necessary to sort by ID to ensure that references are never broken.
For example, when importing threads, especially those created all at once from the web interface, the date of two consecutive tweets may be exactly the same.