feat: Refactor some parts of Torin #807

marc2332 · 2024-08-06T17:55:23Z

No description provided.

… e.g scroll views

github-actions · 2024-08-06T19:52:28Z

Benchmark for `fe47d5c`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	110.5±2.50ms	106.3±0.43ms	-3.80%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.9±0.58ms	28.0±0.64ms	+8.11%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1485.0±14.20µs	1546.5±28.34µs	+4.14%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	144.0±3.50µs	147.5±2.28µs	+2.43%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.1±0.75ms	24.8±0.63ms	-1.20%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1745.9±10.94µs	1717.1±45.28µs	-1.65%
benchmarks/size=19531 depth=7 wide=5 mode=cached	337.5±20.51µs	324.3±16.17µs	-3.91%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.8±0.03ms	2.6±0.03ms	-7.14%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	422.3±38.75µs	416.1±145.81µs	-1.47%
benchmarks/size=54241 depth=5 wide=15 mode=cached	255.3±19.96µs	261.1±28.85µs	+2.27%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.7±0.11ms	6.4±0.13ms	-4.48%

github-actions · 2024-08-06T19:58:13Z

Benchmark for `ac2d265`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.9±0.32ms	105.7±0.22ms	-2.94%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.1±0.29ms	25.9±0.57ms	+7.47%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1483.0±9.83µs	1599.8±20.70µs	+7.88%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	143.0±0.79µs	157.6±3.81µs	+10.21%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.4±0.24ms	23.2±0.17ms	-0.85%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1738.2±5.20µs	1686.1±38.85µs	-3.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached	308.6±1.54µs	307.6±2.39µs	-0.32%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.01ms	2.6±0.01ms	-3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	428.5±108.41µs	411.5±73.55µs	-3.97%
benchmarks/size=54241 depth=5 wide=15 mode=cached	242.9±7.69µs	242.6±5.59µs	-0.12%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.09ms	6.4±0.28ms	-3.03%

codecov · 2024-08-06T20:07:17Z

Codecov Report

Attention: Patch coverage is 95.51402% with 24 lines in your changes missing coverage. Please review.

Project coverage is 73.77%. Comparing base (b872e5b) to head (e232b56).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torin/src/measure.rs	95.87%	21 Missing ⚠️
crates/torin/src/geometry.rs	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   73.80%   73.77%   -0.04%     
==========================================
  Files         201      200       -1     
  Lines       21533    21491      -42     
==========================================
- Hits        15893    15855      -38     
+ Misses       5640     5636       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-06T21:20:59Z

Benchmark for `93622fa`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	110.0±0.99ms	101.6±0.92ms	-7.64%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	26.9±1.13ms	26.5±1.50ms	-1.49%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1495.8±142.68µs	1538.0±54.78µs	+2.82%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	142.2±1.62µs	149.1±2.17µs	+4.85%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.7±0.59ms	24.6±0.45ms	-0.40%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1785.1±97.20µs	1802.1±9.49µs	+0.95%
benchmarks/size=19531 depth=7 wide=5 mode=cached	321.0±14.54µs	324.8±11.40µs	+1.18%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.10ms	2.8±0.11ms	+3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	426.1±131.58µs	443.0±148.51µs	+3.97%
benchmarks/size=54241 depth=5 wide=15 mode=cached	257.6±34.79µs	274.6±28.57µs	+6.60%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.9±0.66ms	7.0±0.37ms	+1.45%

github-actions · 2024-08-06T22:05:28Z

Benchmark for `add90d8`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	113.0±2.13ms	102.5±0.77ms	-9.29%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	27.1±0.76ms	27.9±1.41ms	+2.95%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1497.3±21.83µs	1555.4±119.14µs	+3.88%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	143.9±1.39µs	147.9±1.21µs	+2.78%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.3±0.62ms	25.4±0.79ms	+0.40%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	2.1±0.51ms	1887.5±145.52µs	-10.12%
benchmarks/size=19531 depth=7 wide=5 mode=cached	340.1±25.57µs	354.4±37.36µs	+4.20%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.8±0.07ms	2.9±0.22ms	+3.57%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	427.3±59.70µs	437.3±71.77µs	+2.34%
benchmarks/size=54241 depth=5 wide=15 mode=cached	355.5±78.05µs	324.1±74.22µs	-8.83%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.8±0.35ms	7.2±0.48ms	+5.88%

github-actions · 2024-08-06T22:45:08Z

Benchmark for `525e91e`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.5±0.58ms	100.9±0.85ms	-7.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.5±1.06ms	25.0±1.40ms	-1.96%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1501.1±102.48µs	1545.2±16.64µs	+2.94%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.6±1.02µs	149.3±7.17µs	+5.44%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.4±0.81ms	24.2±0.56ms	-4.72%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1746.8±6.71µs	1789.1±35.35µs	+2.42%
benchmarks/size=19531 depth=7 wide=5 mode=cached	311.9±4.81µs	310.8±8.65µs	-0.35%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.02ms	2.8±0.03ms	+3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	425.3±150.80µs	444.9±74.47µs	+4.61%
benchmarks/size=54241 depth=5 wide=15 mode=cached	247.4±13.22µs	245.8±17.31µs	-0.65%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.09ms	6.9±0.07ms	+4.55%

github-actions · 2024-08-07T17:10:34Z

Benchmark for `0772ced`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	110.7±1.36ms	101.8±0.96ms	-8.04%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	27.6±1.59ms	29.2±1.81ms	+5.80%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1488.1±27.77µs	1543.5±14.96µs	+3.72%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	144.4±0.99µs	150.0±2.11µs	+3.88%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	26.1±0.51ms	26.2±1.26ms	+0.38%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	2.0±0.25ms	1817.5±68.07µs	-9.12%
benchmarks/size=19531 depth=7 wide=5 mode=cached	399.4±56.86µs	337.6±19.56µs	-15.47%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	3.5±0.43ms	2.8±0.10ms	-20.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	430.0±82.38µs	443.7±146.00µs	+3.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached	265.2±30.27µs	399.1±81.54µs	+50.49%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.8±0.31ms	8.2±0.80ms	+20.59%

crates/torin/src/geometry.rs

crates/torin/src/values/size.rs

github-actions · 2024-08-17T21:23:10Z

Benchmark for `aaae916`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	109.5±0.41ms	103.3±1.63ms	-5.66%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.6±0.82ms	26.6±1.19ms	+3.91%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1468.0±10.44µs	1532.3±62.23µs	+4.38%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	142.0±1.76µs	150.5±6.37µs	+5.99%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.5±0.42ms	24.7±0.44ms	+0.82%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1737.5±9.14µs	1824.5±60.31µs	+5.01%
benchmarks/size=19531 depth=7 wide=5 mode=cached	313.7±5.86µs	315.2±6.97µs	+0.48%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.06ms	2.8±0.03ms	+3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	429.0±46.29µs	442.4±148.68µs	+3.12%
benchmarks/size=54241 depth=5 wide=15 mode=cached	263.2±168.17µs	256.3±16.93µs	-2.62%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.09ms	6.9±0.14ms	+4.55%

github-actions · 2024-08-18T09:21:56Z

Benchmark for `66f7d5e`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	109.2±0.24ms	102.5±0.13ms	-6.14%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	23.6±0.34ms	24.5±0.98ms	+3.81%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1478.7±11.80µs	1539.7±6.05µs	+4.13%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.6±2.43µs	150.4±1.71µs	+6.21%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.7±0.15ms	23.6±0.24ms	-0.42%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1740.8±28.61µs	1818.6±35.25µs	+4.47%
benchmarks/size=19531 depth=7 wide=5 mode=cached	311.0±1.48µs	313.1±5.22µs	+0.68%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.01ms	2.8±0.01ms	+3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	423.7±110.55µs	440.2±2.82µs	+3.89%
benchmarks/size=54241 depth=5 wide=15 mode=cached	243.3±162.30µs	245.1±6.89µs	+0.74%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.16ms	7.0±0.05ms	+6.06%

github-actions · 2024-08-18T09:32:35Z

Benchmark for `e675bec`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	110.7±3.39ms	124.9±3.24ms	+12.83%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.7±0.99ms	28.2±1.57ms	+9.73%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1465.3±10.41µs	1749.6±147.93µs	+19.40%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.5±1.83µs	166.3±1.91µs	+17.53%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.2±0.61ms	26.1±0.52ms	+7.85%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1738.2±51.57µs	1969.7±51.39µs	+13.32%
benchmarks/size=19531 depth=7 wide=5 mode=cached	313.4±6.22µs	330.2±18.46µs	+5.36%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.03ms	3.0±0.02ms	+11.11%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	424.0±131.27µs	475.7±57.98µs	+12.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached	276.9±123.56µs	267.3±155.47µs	-3.47%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.27ms	7.8±0.26ms	+18.18%

github-actions · 2024-08-18T09:34:54Z

Benchmark for `72105d7`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	109.8±1.11ms	105.4±1.51ms	-4.01%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.5±1.40ms	27.8±1.02ms	+9.02%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1469.9±13.87µs	1560.5±8.24µs	+6.16%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.7±1.51µs	153.6±1.72µs	+8.40%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.4±0.60ms	25.3±0.46ms	+3.69%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1731.1±30.53µs	1821.5±15.16µs	+5.22%
benchmarks/size=19531 depth=7 wide=5 mode=cached	314.2±19.20µs	312.4±16.41µs	-0.57%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.11ms	2.9±0.02ms	+7.41%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	423.5±133.22µs	445.5±77.76µs	+5.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached	258.9±26.79µs	274.1±25.66µs	+5.87%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.7±0.36ms	7.2±0.08ms	+7.46%

github-actions · 2024-08-18T09:34:59Z

Benchmark for `4ef5d0c`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.0±0.54ms	106.3±0.55ms	-1.57%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	26.4±0.98ms	26.1±1.17ms	-1.14%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1477.7±39.24µs	1580.4±30.93µs	+6.95%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.0±0.98µs	152.8±2.86µs	+8.37%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.9±0.55ms	25.4±0.63ms	-1.93%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1760.1±54.58µs	1811.8±7.61µs	+2.94%
benchmarks/size=19531 depth=7 wide=5 mode=cached	332.9±28.50µs	342.9±18.36µs	+3.00%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.05ms	2.8±0.02ms	+3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	421.3±76.38µs	449.2±128.75µs	+6.62%
benchmarks/size=54241 depth=5 wide=15 mode=cached	267.2±24.96µs	277.3±84.38µs	+3.78%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.15ms	7.3±0.08ms	+10.61%

github-actions · 2024-08-18T09:36:20Z

Benchmark for `7a76028`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.5±0.63ms	114.4±1.46ms	+5.44%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	26.8±1.49ms	28.3±1.00ms	+5.60%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1477.7±16.47µs	1671.5±41.67µs	+13.11%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	142.1±1.13µs	162.3±1.51µs	+14.22%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	26.1±1.34ms	26.3±0.45ms	+0.77%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1772.3±71.75µs	1906.5±11.68µs	+7.57%
benchmarks/size=19531 depth=7 wide=5 mode=cached	313.7±5.30µs	336.8±19.43µs	+7.36%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.02ms	3.0±0.03ms	+11.11%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	421.4±2.73µs	467.8±78.14µs	+11.01%
benchmarks/size=54241 depth=5 wide=15 mode=cached	256.9±22.78µs	284.3±46.86µs	+10.67%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.20ms	7.7±0.20ms	+16.67%

github-actions · 2024-08-18T09:43:39Z

Benchmark for `f9c8c2a`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.5±0.50ms	102.9±0.65ms	-5.16%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.1±0.95ms	26.9±1.31ms	+7.17%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1465.8±16.26µs	1553.8±10.61µs	+6.00%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.0±2.12µs	149.8±1.93µs	+6.24%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.6±0.33ms	25.4±0.58ms	+7.63%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1752.5±15.35µs	1814.6±33.25µs	+3.54%
benchmarks/size=19531 depth=7 wide=5 mode=cached	308.9±5.74µs	314.9±13.40µs	+1.94%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.02ms	3.0±0.24ms	+11.11%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	424.3±133.52µs	446.4±128.20µs	+5.21%
benchmarks/size=54241 depth=5 wide=15 mode=cached	246.0±16.28µs	362.4±44.42µs	+47.32%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.5±0.07ms	7.5±0.46ms	+15.38%

github-actions · 2024-08-18T09:44:00Z

Benchmark for `dcd5dec`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	109.2±0.53ms	109.8±0.38ms	+0.55%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.8±1.07ms	26.1±0.99ms	+5.24%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1481.3±7.54µs	1649.1±62.99µs	+11.33%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.7±1.03µs	158.8±1.55µs	+12.07%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.9±0.69ms	24.6±0.38ms	-1.20%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1735.4±42.39µs	1868.7±23.53µs	+7.68%
benchmarks/size=19531 depth=7 wide=5 mode=cached	309.7±7.66µs	317.7±4.53µs	+2.58%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.03ms	2.9±0.01ms	+7.41%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	421.8±63.84µs	454.6±58.95µs	+7.78%
benchmarks/size=54241 depth=5 wide=15 mode=cached	249.1±19.11µs	261.2±31.32µs	+4.86%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.09ms	7.6±0.21ms	+15.15%

github-actions · 2024-08-18T09:56:06Z

Benchmark for `86c1ef7`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	110.3±3.90ms	105.6±0.60ms	-4.26%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.6±0.68ms	28.3±0.98ms	+15.04%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1460.2±13.30µs	1623.6±20.16µs	+11.19%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.9±7.29µs	157.1±0.99µs	+10.71%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.8±0.30ms	26.8±1.91ms	+12.61%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1725.5±33.76µs	1838.8±22.92µs	+6.57%
benchmarks/size=19531 depth=7 wide=5 mode=cached	317.2±16.84µs	332.9±14.20µs	+4.95%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.03ms	2.9±0.03ms	+7.41%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	420.4±77.40µs	443.0±39.05µs	+5.38%
benchmarks/size=54241 depth=5 wide=15 mode=cached	250.9±24.28µs	264.1±27.69µs	+5.26%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.5±0.04ms	7.6±0.35ms	+16.92%

github-actions · 2024-08-18T10:04:40Z

Benchmark for `b24298e`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.8±0.42ms	104.7±0.47ms	-3.77%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.2±0.55ms	25.2±0.81ms	+4.13%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1476.2±39.53µs	1589.9±10.61µs	+7.70%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	141.3±1.02µs	154.8±0.87µs	+9.55%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.5±0.43ms	24.1±0.45ms	+2.55%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1744.3±66.46µs	1800.0±38.08µs	+3.19%
benchmarks/size=19531 depth=7 wide=5 mode=cached	312.7±3.26µs	311.1±3.91µs	-0.51%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.02ms	2.9±0.04ms	+7.41%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	426.2±102.14µs	441.8±102.76µs	+3.66%
benchmarks/size=54241 depth=5 wide=15 mode=cached	247.0±14.59µs	256.6±19.39µs	+3.89%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.06ms	7.4±0.32ms	+12.12%

github-actions · 2024-08-18T10:20:29Z

Benchmark for `73ce574`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	117.4±1.35ms	107.8±2.08ms	-8.18%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.7±0.98ms	24.6±1.07ms	-4.28%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1485.5±72.27µs	1421.1±21.20µs	-4.34%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	142.2±1.18µs	137.0±2.26µs	-3.66%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.1±0.63ms	23.8±0.50ms	-1.24%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1781.6±162.76µs	1740.3±53.00µs	-2.32%
benchmarks/size=19531 depth=7 wide=5 mode=cached	324.2±37.70µs	317.8±8.24µs	-1.97%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.02ms	2.6±0.02ms	-3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	428.0±151.08µs	409.5±3.59µs	-4.32%
benchmarks/size=54241 depth=5 wide=15 mode=cached	265.2±33.24µs	262.5±37.48µs	-1.02%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	7.0±0.45ms	6.7±0.53ms	-4.29%

github-actions · 2024-08-18T10:29:57Z

Benchmark for `115f600`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.6±0.51ms	106.9±2.73ms	-1.57%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.5±0.79ms	25.1±1.12ms	-1.57%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1480.7±23.49µs	1424.1±21.86µs	-3.82%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	140.6±0.94µs	136.4±1.17µs	-2.99%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.4±0.49ms	23.9±0.67ms	-2.05%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1721.9±39.18µs	1697.5±70.11µs	-1.42%
benchmarks/size=19531 depth=7 wide=5 mode=cached	319.3±14.93µs	325.7±19.57µs	+2.00%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.05ms	2.7±0.09ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	424.9±114.34µs	414.0±128.69µs	-2.57%
benchmarks/size=54241 depth=5 wide=15 mode=cached	260.5±132.65µs	263.5±131.74µs	+1.15%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.7±0.12ms	6.4±0.36ms	-4.48%

marc2332 added 9 commits August 4, 2024 16:32

fix(torin): Consider padding when accumulating inner sizes, used in…

0d632b2

… e.g scroll views

experiments

6652b2a

refactor: Start refactoring Torin

ae2874d

chore: Clean up and fixes

d538057

feat: MeasureContext

eebe89d

chore: Clean up

a0ae9fa

chore: add clipping back to Button

1b08643

chore: Update counter.rs

69538d7

chore: Update counter.rs

11dfa20

marc2332 added the internal impovement👍 Internal code improvements label Aug 6, 2024

chore: Resolve conflicts

2c75539

deno-deploy bot deployed to Preview August 6, 2024 19:47 View deployment

fix: inner percentage

1b4c9fe

deno-deploy bot deployed to Preview August 6, 2024 19:52 View deployment

deno-deploy bot deployed to Preview August 6, 2024 21:15 View deployment

deno-deploy bot deployed to Preview August 6, 2024 22:00 View deployment

deno-deploy bot deployed to Preview August 6, 2024 22:39 View deployment

marc2332 force-pushed the refactor/torin branch from 7299493 to 749af87 Compare August 7, 2024 17:03

marc2332 marked this pull request as ready for review August 17, 2024 21:16

marc2332 commented Aug 17, 2024

View reviewed changes

deno-deploy bot deployed to Preview August 17, 2024 21:19 View deployment

marc2332 force-pushed the refactor/torin branch from 58d4d33 to 16ed0f1 Compare August 18, 2024 09:37

deno-deploy bot deployed to Preview August 18, 2024 09:38 View deployment

deno-deploy bot deployed to Preview August 18, 2024 09:50 View deployment

deno-deploy bot deployed to Preview August 18, 2024 09:59 View deployment

marc2332 force-pushed the refactor/torin branch from 867bdc5 to 1b4c9fe Compare August 18, 2024 10:14

Merge branch 'main' into refactor/torin

e232b56

deno-deploy bot deployed to Preview August 18, 2024 10:24 View deployment

marc2332 merged commit 182e1e0 into main Aug 30, 2024

marc2332 deleted the refactor/torin branch August 30, 2024 17:20

This was referenced Aug 30, 2024

chore: release #828

Closed

chore: release #830

Closed

chore: release #831

Closed

chore: release #845

Closed

This was referenced Sep 10, 2024

chore: release #862

Closed

chore: release #866

Closed

chore: release #870

Closed

chore: release #872

Closed

chore: release #874

Closed

chore: release #881

Closed

chore: release #891

Closed

Uh oh!

feat: Refactor some parts of Torin #807

feat: Refactor some parts of Torin #807

Uh oh!

Conversation

marc2332 commented Aug 6, 2024

Uh oh!

github-actions bot commented Aug 6, 2024

Benchmark for fe47d5c

Uh oh!

github-actions bot commented Aug 6, 2024

Benchmark for ac2d265

Uh oh!

codecov bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 6, 2024

Benchmark for 93622fa

Uh oh!

github-actions bot commented Aug 6, 2024

Benchmark for add90d8

Uh oh!

github-actions bot commented Aug 6, 2024

Benchmark for 525e91e

Uh oh!

github-actions bot commented Aug 7, 2024

Benchmark for 0772ced

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 17, 2024

Benchmark for aaae916

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for 66f7d5e

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for e675bec

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for 72105d7

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for 4ef5d0c

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for 7a76028

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for f9c8c2a

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for dcd5dec

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for 86c1ef7

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for b24298e

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for 73ce574

Uh oh!

github-actions bot commented Aug 18, 2024

Benchmark for 115f600

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Benchmark for `fe47d5c`

Benchmark for `ac2d265`

codecov bot commented Aug 6, 2024 •

edited

Loading

Benchmark for `93622fa`

Benchmark for `add90d8`

Benchmark for `525e91e`

Benchmark for `0772ced`

Benchmark for `aaae916`

Benchmark for `66f7d5e`

Benchmark for `e675bec`

Benchmark for `72105d7`

Benchmark for `4ef5d0c`

Benchmark for `7a76028`

Benchmark for `f9c8c2a`

Benchmark for `dcd5dec`

Benchmark for `86c1ef7`

Benchmark for `b24298e`

Benchmark for `73ce574`

Benchmark for `115f600`