feat: `PluginHandle` #793

marc2332 · 2024-07-15T17:33:33Z

New PluginHandle API for Plugins to interact with the app by e.g emitting platform events.

github-actions · 2024-07-15T17:39:30Z

Benchmark for `2f7f19b`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	112.6±0.25ms	112.6±0.69ms	0.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.7±0.63ms	25.0±1.30ms	+1.21%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1483.4±33.21µs	1476.9±9.37µs	-0.44%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	143.8±0.95µs	144.2±0.85µs	+0.28%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.1±0.35ms	24.3±0.38ms	+0.83%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1766.5±133.35µs	1723.5±24.42µs	-2.43%
benchmarks/size=19531 depth=7 wide=5 mode=cached	312.1±11.23µs	310.9±3.41µs	-0.38%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.01ms	2.7±0.01ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	427.6±155.39µs	420.5±38.57µs	-1.66%
benchmarks/size=54241 depth=5 wide=15 mode=cached	249.6±12.05µs	245.2±14.37µs	-1.76%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.7±0.06ms	6.6±0.08ms	-1.49%

github-actions · 2024-07-15T18:03:29Z

Benchmark for `d698391`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	110.4±1.69ms	111.2±0.23ms	+0.72%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.2±0.34ms	24.6±1.45ms	+1.65%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1475.6±7.23µs	1462.2±8.69µs	-0.91%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	144.3±1.60µs	144.0±1.81µs	-0.21%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.3±0.81ms	23.7±0.18ms	-2.47%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1725.3±6.34µs	1736.5±28.66µs	+0.65%
benchmarks/size=19531 depth=7 wide=5 mode=cached	316.8±6.42µs	312.9±2.82µs	-1.23%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.06ms	2.7±0.04ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	422.5±134.30µs	424.8±131.86µs	+0.54%
benchmarks/size=54241 depth=5 wide=15 mode=cached	262.0±21.18µs	248.7±9.37µs	-5.08%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.8±0.18ms	6.6±0.06ms	-2.94%

marc2332 · 2024-07-15T18:08:34Z

TODO: Use gilrs effect system for better mouse movement in the example gamepad_trace. https://gitlab.com/gilrs-project/gilrs/-/blob/master/gilrs/examples/ff_pos.rs?ref_type=heads

github-actions · 2024-07-15T18:09:02Z

Benchmark for `5323d75`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	116.5±1.97ms	114.9±0.64ms	-1.37%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	27.6±0.60ms	29.3±1.11ms	+6.16%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1527.6±97.48µs	1642.7±41.73µs	+7.53%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	146.1±1.78µs	159.1±1.86µs	+8.90%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	26.0±0.71ms	25.6±0.55ms	-1.54%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1977.6±137.12µs	2.1±0.19ms	+6.19%
benchmarks/size=19531 depth=7 wide=5 mode=cached	404.0±33.35µs	378.0±40.38µs	-6.44%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	3.2±0.21ms	3.1±0.22ms	-3.13%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	424.3±50.63µs	425.9±150.25µs	+0.38%
benchmarks/size=54241 depth=5 wide=15 mode=cached	387.3±82.45µs	418.0±202.20µs	+7.93%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	7.4±0.63ms	7.3±0.52ms	-1.35%

github-actions · 2024-07-15T18:13:21Z

Benchmark for `d90b667`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	115.4±0.43ms	110.2±0.46ms	-4.51%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.7±0.57ms	24.2±0.80ms	-2.02%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1462.9±12.84µs	1480.9±11.95µs	+1.23%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	144.0±1.72µs	145.4±1.41µs	+0.97%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	23.2±0.37ms	23.5±0.35ms	+1.29%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1732.0±46.10µs	1763.0±87.21µs	+1.79%
benchmarks/size=19531 depth=7 wide=5 mode=cached	329.5±25.80µs	319.3±15.91µs	-3.10%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.21ms	2.7±0.02ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	423.6±135.21µs	424.4±130.73µs	+0.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached	256.9±127.27µs	249.4±14.93µs	-2.92%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.6±0.07ms	6.6±0.10ms	0.00%

github-actions · 2024-07-15T18:16:11Z

Benchmark for `f05b0e1`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	115.8±0.88ms	116.3±1.51ms	+0.43%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	26.5±0.92ms	26.6±1.25ms	+0.38%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1497.2±25.80µs	1506.1±17.14µs	+0.59%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	144.7±1.68µs	144.6±1.59µs	-0.07%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.3±0.63ms	25.5±1.08ms	+0.79%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1761.5±52.03µs	1746.2±44.88µs	-0.87%
benchmarks/size=19531 depth=7 wide=5 mode=cached	327.9±28.12µs	323.6±12.64µs	-1.31%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.06ms	2.7±0.08ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	426.3±82.65µs	428.6±153.11µs	+0.54%
benchmarks/size=54241 depth=5 wide=15 mode=cached	260.2±34.68µs	280.3±41.00µs	+7.72%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.7±0.20ms	6.8±0.43ms	+1.49%

codecov · 2024-07-15T18:22:48Z

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 73.62%. Comparing base (182e1e0) to head (f200216).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/renderer/src/app.rs	0.00%	50 Missing ⚠️
crates/core/src/plugins.rs	0.00%	15 Missing ⚠️
crates/freya/src/plugins/performance_overlay.rs	0.00%	1 Missing ⚠️
crates/renderer/src/renderer.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   73.76%   73.62%   -0.15%     
==========================================
  Files         200      200              
  Lines       21502    21543      +41     
==========================================
  Hits        15862    15862              
- Misses       5640     5681      +41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-03T08:23:03Z

Benchmark for `fd5488d`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	115.3±1.32ms	114.5±0.47ms	-0.69%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	28.6±0.80ms	29.6±1.00ms	+3.50%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1500.0±16.14µs	1542.1±24.72µs	+2.81%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	145.5±1.32µs	149.2±0.99µs	+2.54%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	29.1±0.94ms	26.7±0.34ms	-8.25%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1842.2±58.82µs	1868.6±69.24µs	+1.43%
benchmarks/size=19531 depth=7 wide=5 mode=cached	383.2±21.68µs	373.5±19.05µs	-2.53%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.8±0.05ms	3.0±0.25ms	+7.14%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	425.4±79.26µs	424.4±53.60µs	-0.24%
benchmarks/size=54241 depth=5 wide=15 mode=cached	372.7±52.67µs	359.9±38.46µs	-3.43%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	7.6±0.31ms	7.8±0.77ms	+2.63%

github-actions · 2024-08-04T14:41:57Z

Benchmark for `0b47b57`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	110.8±0.51ms	109.0±0.44ms	-1.62%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.9±0.63ms	26.0±1.12ms	+0.39%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1486.1±17.01µs	1486.1±34.16µs	0.00%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	142.3±1.44µs	142.6±2.14µs	+0.21%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.5±0.59ms	24.8±0.36ms	-2.75%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1746.8±11.85µs	1767.0±54.34µs	+1.16%
benchmarks/size=19531 depth=7 wide=5 mode=cached	321.0±7.90µs	314.3±5.57µs	-2.09%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.02ms	2.7±0.01ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	425.6±75.85µs	426.4±149.10µs	+0.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached	253.6±18.78µs	252.3±13.21µs	-0.51%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.9±0.05ms	6.7±0.17ms	-2.90%

github-actions · 2024-08-30T17:28:24Z

Benchmark for `f1352a4`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	106.2±0.73ms	107.8±2.17ms	+1.51%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	25.3±0.77ms	26.5±1.39ms	+4.74%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1426.9±16.41µs	1435.4±69.07µs	+0.60%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	137.0±1.99µs	139.0±2.12µs	+1.46%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.9±0.65ms	24.8±0.70ms	-0.40%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1710.0±37.58µs	1756.8±91.32µs	+2.74%
benchmarks/size=19531 depth=7 wide=5 mode=cached	334.0±31.02µs	332.4±26.87µs	-0.48%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.8±0.20ms	2.7±0.20ms	-3.57%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	413.1±130.79µs	413.4±77.03µs	+0.07%
benchmarks/size=54241 depth=5 wide=15 mode=cached	312.7±66.59µs	295.2±61.79µs	-5.60%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.5±0.30ms	6.6±0.37ms	+1.54%

github-actions · 2024-08-30T17:34:08Z

Benchmark for `a2fce02`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	105.4±0.46ms	105.4±0.71ms	0.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	24.7±0.60ms	25.0±1.02ms	+1.21%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1429.6±11.12µs	1448.3±75.23µs	+1.31%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	138.0±0.99µs	136.8±0.81µs	-0.87%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	24.1±0.46ms	24.2±0.51ms	+0.41%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1710.5±6.35µs	1700.2±8.51µs	-0.60%
benchmarks/size=19531 depth=7 wide=5 mode=cached	313.6±8.23µs	313.9±4.22µs	+0.10%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.6±0.02ms	2.6±0.02ms	0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	418.0±121.86µs	412.3±58.67µs	-1.36%
benchmarks/size=54241 depth=5 wide=15 mode=cached	246.7±12.73µs	254.5±16.92µs	+3.16%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.4±0.06ms	6.4±0.09ms	0.00%

github-actions · 2024-08-30T17:38:12Z

Benchmark for `29804e4`

Click to view benchmark

Test	Base	PR	%
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached	108.0±1.03ms	107.4±1.33ms	-0.56%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached	26.4±1.22ms	28.0±1.21ms	+6.06%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached	1461.9±22.48µs	1440.4±36.31µs	-1.47%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached	139.6±1.72µs	138.5±1.62µs	-0.79%
benchmarks/size=131071 depth=17 wide=2 mode=not cached	25.9±1.00ms	25.7±1.16ms	-0.77%
benchmarks/size=16383 depth=14 wide=2 mode=not cached	1693.4±21.16µs	1826.1±219.45µs	+7.84%
benchmarks/size=19531 depth=7 wide=5 mode=cached	329.9±26.74µs	356.2±36.83µs	+7.97%
benchmarks/size=19531 depth=7 wide=5 mode=not cached	2.7±0.07ms	2.6±0.04ms	-3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached	415.2±109.92µs	417.2±149.22µs	+0.48%
benchmarks/size=54241 depth=5 wide=15 mode=cached	273.9±29.19µs	283.6±66.16µs	+3.54%
benchmarks/size=54241 depth=5 wide=15 mode=not cached	6.7±0.32ms	6.5±0.34ms	-2.99%

feat: PluginHandle

1c2fe38

marc2332 added the enhancement 🔥 New feature or request label Jul 15, 2024

deno-deploy bot deployed to Preview July 15, 2024 17:34 View deployment

gamepad_focus

3934f30

deno-deploy bot deployed to Preview July 15, 2024 17:58 View deployment

fix ci

63e2e2b

deno-deploy bot deployed to Preview July 15, 2024 18:03 View deployment

install libudev-sys in CI

84a80a1

actually install libudev-dev in CI

f74c632

Merge branch 'main' into feat/plugin-handle

f692bbb

deno-deploy bot deployed to Preview August 3, 2024 08:16 View deployment

deno-deploy bot deployed to Preview August 3, 2024 08:17 View deployment

chore: Clean up

5385983

deno-deploy bot deployed to Preview August 4, 2024 14:36 View deployment

Merge branch 'main' into feat/plugin-handle

f8f520a

deno-deploy bot deployed to Preview August 30, 2024 17:22 View deployment

deno-deploy bot deployed to Preview August 30, 2024 17:23 View deployment

chore: Doc comment

11cc2fa

deno-deploy bot deployed to Preview August 30, 2024 17:29 View deployment

chore: fmt

f200216

marc2332 marked this pull request as ready for review August 30, 2024 17:32

marc2332 merged commit f8a0844 into main Aug 30, 2024

marc2332 deleted the feat/plugin-handle branch August 30, 2024 17:42

This was referenced Aug 30, 2024

chore: release #830

Closed

chore: release #831

Closed

chore: release #845

Closed

This was referenced Sep 10, 2024

chore: release #862

Closed

chore: release #866

Closed

chore: release #870

Closed

chore: release #872

Closed

chore: release #874

Closed

chore: release #881

Closed

chore: release #891

Closed

Uh oh!

feat: PluginHandle #793

feat: PluginHandle #793

Uh oh!

Conversation

marc2332 commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2024

Benchmark for 2f7f19b

Uh oh!

github-actions bot commented Jul 15, 2024

Benchmark for d698391

Uh oh!

marc2332 commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2024

Benchmark for 5323d75

Uh oh!

github-actions bot commented Jul 15, 2024

Benchmark for d90b667

Uh oh!

github-actions bot commented Jul 15, 2024

Benchmark for f05b0e1

Uh oh!

codecov bot commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 3, 2024

Benchmark for fd5488d

Uh oh!

github-actions bot commented Aug 4, 2024

Benchmark for 0b47b57

Uh oh!

github-actions bot commented Aug 30, 2024

Benchmark for f1352a4

Uh oh!

github-actions bot commented Aug 30, 2024

Benchmark for a2fce02

Uh oh!

github-actions bot commented Aug 30, 2024

Benchmark for 29804e4

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: `PluginHandle` #793

feat: `PluginHandle` #793

marc2332 commented Jul 15, 2024 •

edited

Loading

Benchmark for `2f7f19b`

Benchmark for `d698391`

marc2332 commented Jul 15, 2024 •

edited

Loading

Benchmark for `5323d75`

Benchmark for `d90b667`

Benchmark for `f05b0e1`

codecov bot commented Jul 15, 2024 •

edited

Loading

Benchmark for `fd5488d`

Benchmark for `0b47b57`

Benchmark for `f1352a4`

Benchmark for `a2fce02`

Benchmark for `29804e4`