Skip to content

Conversation

@marc2332
Copy link
Owner

@marc2332 marc2332 commented Jul 1, 2024

Closes #454

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jul 1, 2024
@codecov
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 67.25490% with 167 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (094d2d5) to head (acb814f).

Files Patch % Lines
crates/state/src/font_style.rs 24.74% 73 Missing ⚠️
crates/state/src/layout.rs 64.55% 28 Missing ⚠️
crates/state/src/style.rs 54.23% 27 Missing ⚠️
crates/state/src/cursor.rs 71.79% 11 Missing ⚠️
crates/state/src/accessibility.rs 66.66% 9 Missing ⚠️
crates/state/src/parsing.rs 73.33% 4 Missing ⚠️
crates/state/src/values/font.rs 20.00% 4 Missing ⚠️
crates/state/src/transform.rs 85.71% 3 Missing ⚠️
crates/state/src/values/color.rs 89.28% 3 Missing ⚠️
crates/state/src/layer.rs 89.47% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   73.57%   73.69%   +0.11%     
==========================================
  Files         199      199              
  Lines       20397    20427      +30     
==========================================
+ Hits        15008    15053      +45     
+ Misses       5389     5374      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review July 9, 2024 19:45
@marc2332 marc2332 merged commit 06aaa9e into main Jul 9, 2024
@marc2332 marc2332 deleted the feat/panic-on-wrongly-formatted-attributes-in-debug-builds branch July 9, 2024 19:45
This was referenced Jul 9, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🔥 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

idea: Panic wrongly-formatted attribute values in Debug builds

2 participants