fix: Skip DOM Nodes loaded in the same mutations run #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc2332
force-pushed
the
fix/skip-dom-nodes-loaded-in-the-same-mutations-run
branch
from
4fb4adb to
38948f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 198 198
Lines 20352 20362 +10
=======================================
+ Hits 15012 15021 +9
- Misses 5340 5341 +1 ☔ View full report in Codecov by Sentry. |
ZeroX-DG
reviewed
Jun 27, 2024
| // this is mainly due to nodes being created in the same run as when this function (remove) is being called, | ||
| // like nodes created by loaded templates. | ||
| // In this case we can safely skip these nodes. | ||
| if !does_node_have_state { |
Contributor
There was a problem hiding this comment.
Nitpicking: Maybe just call the variable node_state_is_empty = layer_state.is_none() so we don't have to think about the ! 😄 .
Contributor
|
Looks nice. I'll give it a quick test when I'm free. |
Contributor
|
Works great for me! |
This was referenced Jul 6, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 30, 2024
Closed
Closed
Closed
This was referenced Sep 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #602