Skip to content

Conversation

@marc2332
Copy link
Owner

Depends on #729

  • remove unnecessary scale factor casts
  • Use of proper RealDOMAdapter cache between removals

@marc2332 marc2332 added the internal impovement👍 Internal code improvements label Jun 20, 2024
@codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 72.53521% with 39 lines in your changes missing coverage. Please review.

Project coverage is 73.94%. Comparing base (5d99dbe) to head (65f8d11).
Report is 1 commits behind head on main.

Current head 65f8d11 differs from pull request most recent head d4dd542

Please upload reports for the commit d4dd542 to get more accurate results.

Files Patch % Lines
crates/renderer/src/app.rs 0.00% 25 Missing ⚠️
crates/core/src/dom/mutations_writer.rs 86.36% 6 Missing ⚠️
crates/renderer/src/window_state.rs 0.00% 5 Missing ⚠️
crates/renderer/src/renderer.rs 0.00% 2 Missing ⚠️
crates/core/src/dom/dom_adapter.rs 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   73.91%   73.94%   +0.02%     
==========================================
  Files         198      198              
  Lines       20321    20357      +36     
==========================================
+ Hits        15020    15052      +32     
- Misses       5301     5305       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from internal/simplify-virtual-dom-polling to main June 21, 2024 16:03
@marc2332 marc2332 merged commit b182e65 into main Jun 21, 2024
@marc2332 marc2332 deleted the internal/rethink-mutations-writer branch June 21, 2024 16:04
@github-actions github-actions bot mentioned this pull request Jun 21, 2024
marc2332 added a commit that referenced this pull request Jun 21, 2024
marc2332 added a commit that referenced this pull request Jun 21, 2024
This was referenced Jun 21, 2024
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal impovement👍 Internal code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants