Skip to content

Conversation

@marc2332
Copy link
Owner

No description provided.

@marc2332 marc2332 added the enhancement 🔥 New feature or request label May 27, 2024
@codecov
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 73.01%. Comparing base (7137d76) to head (3a63077).

Files Patch % Lines
crates/hooks/src/use_platform.rs 0.00% 45 Missing ⚠️
crates/renderer/src/event_loop.rs 0.00% 2 Missing ⚠️
crates/components/src/graph.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   73.17%   73.01%   -0.17%     
==========================================
  Files         192      192              
  Lines       19106    19149      +43     
==========================================
  Hits        13981    13981              
- Misses       5125     5168      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review May 28, 2024 12:48
@marc2332 marc2332 changed the title feat: With window event feat: WithWindow event May 28, 2024
* feat: `min/max/fullscreen window` in `use_platform`.

Added window features using the new `with_window` event.

- `maximize_window`: When called, maximizes the window if not maximized, or de-maximizes the window if already maximized (standard behaviour).
- `minimize_window`: When called, minimizes the window.
- `fullscreen_window`: When called, fullscreens the window if not fullscreened, or de-fullscreens the window if already fullscreen.

* fix: Update to new API.

Co-authored-by: Marc Espin <[email protected]>

* fix: Update to new API.

Co-authored-by: Marc Espin <[email protected]>

* fix: Update to new API.

Co-authored-by: Marc Espin <[email protected]>

* fix: Update to new API.

Co-authored-by: Marc Espin <[email protected]>

* fix: Update to new API.

Co-authored-by: Marc Espin <[email protected]>

* chore: Clean up

---------

Co-authored-by: Marc Espin <[email protected]>
This was referenced Jun 21, 2024
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🔥 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants