fix: WindowDragArea component hanging on non-left click.
#625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `WindowDragArea` component received a non-left click, the drag area would become disabled, even when receiving standard right click events. Fixed by adding a check in the `onmousedown` function within the component.
Owner
|
Thanks! |
This was referenced May 29, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 17, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 26, 2024
Closed
Closed
Closed
Closed
This was referenced Jul 6, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 27, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
WindowDragAreacomponent received a non-left click, the drag area would become disabled, even when receiving standard right click events.Fixed by adding a check in the
onmousedownfunction within the component.