Skip to content

Conversation

@ZeroX-DG
Copy link
Contributor

Closes #262

@marc2332 marc2332 self-requested a review April 30, 2024 08:41
Copy link
Owner

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like I had it in my mind, I will try it asap. Just left a tiny comment

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Apr 30, 2024
@codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 73.20%. Comparing base (f57adbc) to head (f2e82bf).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/components/src/window_drag_area.rs 0.00% 5 Missing ⚠️
crates/hooks/src/use_platform.rs 0.00% 3 Missing ⚠️
crates/renderer/src/event_loop.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   73.24%   73.20%   -0.05%     
==========================================
  Files         191      192       +1     
  Lines       19127    19138      +11     
==========================================
  Hits        14010    14010              
- Misses       5117     5128      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZeroX-DG ZeroX-DG requested a review from marc2332 April 30, 2024 09:08
@marc2332
Copy link
Owner

Just a comment to clean up the example, it works perfectly!

@ZeroX-DG ZeroX-DG requested a review from marc2332 May 1, 2024 07:52
@marc2332
Copy link
Owner

marc2332 commented May 1, 2024

Just saw https://github.com/ZeroX-DG/raven ! You are crazy haha 🚀

Let me know if you have any issue/doubt/missing feature and I will be happy to help 😄

@marc2332 marc2332 merged commit 7b68806 into marc2332:main May 2, 2024
@ZeroX-DG ZeroX-DG deleted the feat/window-drag-zone branch May 2, 2024 23:55
@ZeroX-DG
Copy link
Contributor Author

ZeroX-DG commented May 2, 2024

Haha thanks! You're doing a great job fixing my feature requests lightning fast haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🔥 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

suggestion: Window drag area

2 participants