Skip to content

Conversation

@ZeroX-DG
Copy link
Contributor

Closes #534

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Apr 29, 2024
@codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.33%. Comparing base (f57adbc) to head (76129a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   73.24%   73.33%   +0.08%     
==========================================
  Files         191      191              
  Lines       19127    19166      +39     
==========================================
+ Hits        14010    14055      +45     
+ Misses       5117     5111       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 self-requested a review April 29, 2024 12:46
@ZeroX-DG ZeroX-DG requested a review from marc2332 April 30, 2024 09:08
Copy link
Owner

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marc2332 marc2332 merged commit f0bf587 into marc2332:main May 1, 2024
@marc2332
Copy link
Owner

marc2332 commented May 1, 2024

Thanks! I appreciate you even added a test!

This was referenced Jun 18, 2024
This was referenced Jun 26, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🔥 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhancement: Support closing Popups with Esc

2 participants