Skip to content

Conversation

@marc2332
Copy link
Owner

@marc2332 marc2332 commented Nov 25, 2023

To DO

  • Fps
  • Render duration
  • Layout duration

@marc2332 marc2332 added enhancement 🔥 New feature or request devtools labels Nov 25, 2023
@marc2332 marc2332 changed the title feat: FPS counter, WIP feat: FPS counter Nov 25, 2023
@codecov
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (e6e2ea1) 52.95% compared to head (6ffb2aa) 52.47%.

Files Patch % Lines
crates/freya/src/plugins/performance_overlay.rs 0.00% 97 Missing ⚠️
crates/renderer/src/app.rs 0.00% 19 Missing ⚠️
crates/torin/src/torin.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   52.95%   52.47%   -0.48%     
==========================================
  Files         144      145       +1     
  Lines       12732    12847     +115     
==========================================
  Hits         6742     6742              
- Misses       5990     6105     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 changed the title feat: FPS counter feat: FPS counter plugin Nov 26, 2023
@marc2332 marc2332 changed the title feat: FPS counter plugin feat: Performance Overlay Plugin Nov 29, 2023
@marc2332 marc2332 changed the base branch from main to feat/plugins-system December 6, 2023 18:48
Base automatically changed from feat/plugins-system to main December 6, 2023 22:20
@github-actions
Copy link

github-actions bot commented Dec 8, 2023

Benchmark for 180b6cc

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + branches + cached) + invalidated node in the middle 993.2±105.04µs 981.3±74.95µs -1.20%
benchmarks/big trees (deep + cached) + invalidated node in the bottom 85.2±1.19µs 84.6±1.43µs -0.70%
benchmarks/big trees (deep + cached) + invalidated node in the middle 100.0±1.82µs 101.7±65.20µs +1.70%
benchmarks/big trees (deep + cached) + invalidated node in the top 154.3±3.82µs 162.0±77.86µs +4.99%
benchmarks/big trees (deep) nodes=10000, depth=14 212.1±6.30µs 216.7±20.07µs +2.17%
benchmarks/big trees (deep) nodes=100000, depth=17 3.5±0.11ms 3.4±0.18ms -2.86%
benchmarks/big trees (deep) nodes=4000, depth=12 105.2±3.15µs 106.2±24.53µs +0.95%
benchmarks/big trees (wide) nodes=1000, depth=1 164.9±7.78µs 163.7±2.15µs -0.73%
benchmarks/big trees (wide) nodes=10000, depth=1 1683.4±11.61µs 1711.7±13.30µs +1.68%
benchmarks/big trees (wide) nodes=100000, depth=1 31.8±0.54ms 32.1±1.22ms +0.94%

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

Benchmark for 09985ad

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + branches + cached) + invalidated node in the middle 1009.8±84.90µs 1043.3±138.20µs +3.32%
benchmarks/big trees (deep + cached) + invalidated node in the bottom 90.0±118.22µs 87.2±49.57µs -3.11%
benchmarks/big trees (deep + cached) + invalidated node in the middle 104.0±110.71µs 102.1±49.85µs -1.83%
benchmarks/big trees (deep + cached) + invalidated node in the top 157.2±2.41µs 157.2±2.33µs 0.00%
benchmarks/big trees (deep) nodes=10000, depth=14 211.1±7.23µs 207.9±6.75µs -1.52%
benchmarks/big trees (deep) nodes=100000, depth=17 3.4±0.12ms 3.3±0.12ms -2.94%
benchmarks/big trees (deep) nodes=4000, depth=12 104.9±1.72µs 106.7±19.46µs +1.72%
benchmarks/big trees (wide) nodes=1000, depth=1 163.9±5.28µs 165.1±1.33µs +0.73%
benchmarks/big trees (wide) nodes=10000, depth=1 2.1±0.06ms 1738.7±116.96µs -17.20%
benchmarks/big trees (wide) nodes=100000, depth=1 31.6±0.79ms 31.5±0.79ms -0.32%

@marc2332 marc2332 merged commit 83f7049 into main Dec 8, 2023
@marc2332 marc2332 deleted the feat/fps-counter branch December 8, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devtools enhancement 🔥 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants