Skip to content

Conversation

@marc2332
Copy link
Owner

@marc2332 marc2332 commented Nov 7, 2023

Closes #329

image

@codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (205b7f2) 53.61% compared to head (ddf1ce1) 53.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   53.61%   53.54%   -0.08%     
==========================================
  Files         133      133              
  Lines       12072    12088      +16     
==========================================
  Hits         6472     6472              
- Misses       5600     5616      +16     
Files Coverage Δ
crates/renderer/src/window.rs 0.00% <0.00%> (ø)
crates/renderer/src/config.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit c372a38 into main Nov 11, 2023
@marc2332 marc2332 deleted the feat/window-icon branch November 11, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🔥 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhancement: Improve LaunchConfigBuilder

2 participants