Skip to content

Conversation

@marc2332
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (601e7e6) 52.62% compared to head (1ead9af) 52.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   52.62%   52.62%           
=======================================
  Files         129      129           
  Lines       11216    11216           
=======================================
  Hits         5902     5902           
  Misses       5314     5314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Benchmark for 929b9ba

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + cached) + invalidated node in the bottom 372.1±4.06ns 110.3±0.24µs +29542.57%
benchmarks/big trees (deep + cached) + invalidated node in the middle 381.6±3.37ns 110.4±0.23µs +28830.82%
benchmarks/big trees (deep + cached) + invalidated node in the top 98.4±0.19µs 207.8±0.37µs +111.18%
benchmarks/big trees (deep) nodes=10000, depth=14 118.2±0.18µs 131.8±0.19µs +11.51%
benchmarks/big trees (deep) nodes=100000, depth=17 1236.8±15.97µs 1266.4±19.83µs +2.39%
benchmarks/big trees (deep) nodes=4000, depth=12 56.3±0.57µs 69.7±0.71µs +23.80%
benchmarks/big trees (wide) nodes=1000, depth=1 167.0±0.41µs 163.9±0.60µs -1.86%
benchmarks/big trees (wide) nodes=10000, depth=1 1996.4±27.90µs 1903.1±8.00µs -4.67%
benchmarks/big trees (wide) nodes=100000, depth=1 35.8±0.36ms 34.7±0.41ms -3.07%

@github-actions
Copy link

Benchmark for 955764f

Click to view benchmark
Test Base PR %
benchmarks/big trees (deep + cached) + invalidated node in the bottom 393.6±45.05ns 105.7±8.23µs +26754.67%
benchmarks/big trees (deep + cached) + invalidated node in the middle 398.3±42.56ns 106.8±9.32µs +26713.96%
benchmarks/big trees (deep + cached) + invalidated node in the top 109.5±9.40µs 209.0±17.35µs +90.87%
benchmarks/big trees (deep) nodes=10000, depth=14 156.3±10.43µs 170.8±14.67µs +9.28%
benchmarks/big trees (deep) nodes=100000, depth=17 1474.3±122.30µs 1386.0±128.88µs -5.99%
benchmarks/big trees (deep) nodes=4000, depth=12 66.5±5.66µs 85.4±7.62µs +28.42%
benchmarks/big trees (wide) nodes=1000, depth=1 208.9±21.24µs 215.4±24.64µs +3.11%
benchmarks/big trees (wide) nodes=10000, depth=1 2.2±0.19ms 2.1±0.18ms -4.55%
benchmarks/big trees (wide) nodes=100000, depth=1 40.2±2.64ms 39.7±2.85ms -1.24%

@marc2332 marc2332 merged commit 724e4e8 into main Sep 24, 2023
@marc2332 marc2332 deleted the fix/pass-children-ids-in-torin-benchmarks branch September 24, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 🩹 Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants