Skip to content

Conversation

@tigerros
Copy link

The torin link was outdated. This updates it and also adds a permalink which will never "expire", unless the repository is deleted, or @marc2332 changes his name.

Copy link
Owner

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, but it shouldn't point to an old version, it should just point to https://github.com/marc2332/freya/tree/main/crates/torin

@tigerros
Copy link
Author

it should just point to https://github.com/marc2332/freya/tree/main/crates/torin

The files might get moved around or something and the link becomes invalid, that's why I thought a permalink would make sense. However, I noticed torin is already on crates.io, so I added a link to there instead of the permalink. Unless you change the name of the crate, it's not going to become invalid. Problem solved.

@tigerros tigerros requested a review from marc2332 September 22, 2023 11:19
@marc2332 marc2332 added documentation Improvements or additions to documentation fix 🩹 Fixes a bug labels Sep 23, 2023
@marc2332 marc2332 changed the title Update Torin link and add permalink so it doesn't happen again fix(docs): Update Torin's link in differences with Dioxus Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (724e4e8) 52.62% compared to head (a8d2c63) 52.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   52.62%   52.62%           
=======================================
  Files         129      129           
  Lines       11216    11216           
=======================================
  Hits         5902     5902           
  Misses       5314     5314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 4dc257c into marc2332:main Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fix 🩹 Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants