fix: remove unnecessary empty section at the end of VirtualScrollView component

[kyteidev]

Removes the empty bit at the end of a VirtualScrollView component to match with a regular ScrollView component.

Video showing the empty bit:

Screen.Recording.2025-05-28.at.22.26.00.mov

The changes related to imports are caused by the code formatter in my code editor.

[marc2332]

The changes related to imports are caused by the code formatter in my code editor.

You can format it correctly like this:

cargo +nightly fmt --all -- --error-on-unformatted --unstable-features

[kyteidev]

Thanks, it is now fixed.

[marc2332]

A test is failing @kyteidev

[kyteidev]

Yes, I noticed. It seems the change I made removes smoother scrolling as it removes the buffer area.

[marc2332]

Yes, I noticed. It seems the change I made removes smoother scrolling as it removes the buffer area.

No, it doesn't remove the smooth scrolling from my testing.

You can update the test to fix it:

        assert_eq!(content.children_ids().len(), 10);

        for (n, i) in (20..30).enumerate() {
            let child = content.get(n);
            assert_eq!(
                child.get(0).text(),
                Some(format!("{i} Hello, World!").as_str())
            );
        }

[kyteidev]

Alright, it is now fixed! I read the comment for the wrong test, so I thought I accidentally removed smooth scrolling lol

[marc2332]

I will cherry-pick this for a 0.3.4 release

[marc2332]

https://github.com/marc2332/freya/milestone/6

[marc2332]

Also, please next time open the pr from a different branch instead of your main ❤️ (it makes it easier for me)

Thanks for the PR anyway, I appreciate it 🦀 😄

[kyteidev]

Ok, thanks for letting me know!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.38%. Comparing base (af22491) to head (6f7a40c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1191   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files         238      238           
  Lines       29402    29402           
=======================================
  Hits        22459    22459           
  Misses       6943     6943           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.